Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 185863003: [Media] Add user gesture reporting for API calls to midi and media streams. (Closed)

Created:
6 years, 9 months ago by Greg Billock
Modified:
6 years, 9 months ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, fischman+watch_chromium.org, tfarina, jam, mcasas+watch_chromium.org, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org, jochen+watch_chromium.org, miu+watch_chromium.org
Visibility:
Public.

Description

[Media] Add user gesture reporting for API calls to midi and media streams. BUG=332115 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260257

Patch Set 1 #

Patch Set 2 : try 2 #

Total comments: 2

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : rebase #

Patch Set 6 : pick up tests #

Patch Set 7 : . #

Total comments: 2

Patch Set 8 : Rebase #

Patch Set 9 : Plumb user_gesture through #

Patch Set 10 : Add android #

Patch Set 11 : rebase #

Patch Set 12 : Fix test merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -31 lines) Patch
M android_webview/browser/aw_browser_context.h View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download
M android_webview/browser/aw_browser_context.cc View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/media/chrome_midi_permission_context.h View 1 2 3 4 5 6 7 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/media/chrome_midi_permission_context.cc View 1 2 3 4 5 6 7 8 8 chunks +10 lines, -4 lines 0 comments Download
M chrome/browser/media/media_stream_devices_controller.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl.h View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl.cc View 1 2 3 4 5 6 7 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_impl.h View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 1 2 3 4 5 6 7 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/app_list/test/fake_profile.h View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/app_list/test/fake_profile.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/base/testing_profile.h View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/base/testing_profile.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/download/download_manager_impl_unittest.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/media/media_stream_dispatcher_host.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/media/media_stream_dispatcher_host.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +5 lines, -3 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/media_stream_manager.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/media/media_stream_manager.cc View 1 2 3 4 5 6 7 8 9 10 11 10 chunks +12 lines, -1 line 0 comments Download
M content/browser/renderer_host/media/media_stream_ui_proxy_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 5 chunks +5 lines, -4 lines 0 comments Download
M content/browser/renderer_host/media/midi_dispatcher_host.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/media/midi_dispatcher_host.cc View 2 chunks +3 lines, -1 line 0 comments Download
M content/common/media/media_stream_messages.h View 1 2 3 4 5 6 7 1 chunk +3 lines, -2 lines 0 comments Download
M content/common/media/midi_messages.h View 1 chunk +3 lines, -2 lines 0 comments Download
M content/public/browser/browser_context.h View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/media_stream_request.h View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +4 lines, -0 lines 0 comments Download
M content/public/common/media_stream_request.cc View 1 2 3 4 5 6 7 2 chunks +2 lines, -0 lines 0 comments Download
M content/public/test/test_browser_context.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/test/test_browser_context.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/media/media_stream_dispatcher.cc View 1 2 3 4 5 6 7 2 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/media/midi_dispatcher.cc View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +3 lines, -1 line 0 comments Download
M content/shell/browser/shell_browser_context.h View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/browser/shell_browser_context.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 44 (0 generated)
Greg Billock
nasko for messages darin for content api tommi for media review
6 years, 9 months ago (2014-03-03 19:51:57 UTC) #1
nasko
LGTM for messages.
6 years, 9 months ago (2014-03-03 22:00:55 UTC) #2
tommi (sloooow) - chröme
lgtm for media https://codereview.chromium.org/185863003/diff/20001/content/browser/renderer_host/media/media_stream_manager.cc File content/browser/renderer_host/media/media_stream_manager.cc (right): https://codereview.chromium.org/185863003/diff/20001/content/browser/renderer_host/media/media_stream_manager.cc#newcode391 content/browser/renderer_host/media/media_stream_manager.cc:391: false, // user gesture nit: only ...
6 years, 9 months ago (2014-03-04 09:57:12 UTC) #3
Greg Billock
https://codereview.chromium.org/185863003/diff/20001/content/browser/renderer_host/media/media_stream_manager.cc File content/browser/renderer_host/media/media_stream_manager.cc (right): https://codereview.chromium.org/185863003/diff/20001/content/browser/renderer_host/media/media_stream_manager.cc#newcode391 content/browser/renderer_host/media/media_stream_manager.cc:391: false, // user gesture On 2014/03/04 09:57:13, tommi wrote: ...
6 years, 9 months ago (2014-03-05 18:24:21 UTC) #4
Greg Billock
The CQ bit was checked by gbillock@chromium.org
6 years, 9 months ago (2014-03-09 22:37:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gbillock@chromium.org/185863003/110001
6 years, 9 months ago (2014-03-09 22:37:30 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-09 23:08:57 UTC) #7
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=54322
6 years, 9 months ago (2014-03-09 23:08:58 UTC) #8
Greg Billock
On 2014/03/09 23:08:58, I haz the power (commit-bot) wrote: > Retried try job too often ...
6 years, 9 months ago (2014-03-12 09:21:06 UTC) #9
Lei Zhang
Is there a bug # associated with this CL? https://codereview.chromium.org/185863003/diff/110001/chrome/browser/media/chrome_midi_permission_context.cc File chrome/browser/media/chrome_midi_permission_context.cc (right): https://codereview.chromium.org/185863003/diff/110001/chrome/browser/media/chrome_midi_permission_context.cc#newcode171 chrome/browser/media/chrome_midi_permission_context.cc:171: ...
6 years, 9 months ago (2014-03-12 22:54:07 UTC) #10
jam
On 2014/03/12 22:54:07, Lei Zhang wrote: > Is there a bug # associated with this ...
6 years, 9 months ago (2014-03-13 21:06:41 UTC) #11
Greg Billock
On 2014/03/13 21:06:41, jam wrote: > On 2014/03/12 22:54:07, Lei Zhang wrote: > > Is ...
6 years, 9 months ago (2014-03-14 08:33:18 UTC) #12
Lei Zhang
On 2014/03/12 22:54:07, Lei Zhang wrote: > Is there a bug # associated with this ...
6 years, 9 months ago (2014-03-14 13:01:38 UTC) #13
Greg Billock
https://codereview.chromium.org/185863003/diff/110001/chrome/browser/media/chrome_midi_permission_context.cc File chrome/browser/media/chrome_midi_permission_context.cc (right): https://codereview.chromium.org/185863003/diff/110001/chrome/browser/media/chrome_midi_permission_context.cc#newcode171 chrome/browser/media/chrome_midi_permission_context.cc:171: bool user_gesture, On 2014/03/12 22:54:08, Lei Zhang wrote: > ...
6 years, 9 months ago (2014-03-24 21:19:41 UTC) #14
Greg Billock
The CQ bit was checked by gbillock@chromium.org
6 years, 9 months ago (2014-03-24 21:19:47 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gbillock@chromium.org/185863003/150001
6 years, 9 months ago (2014-03-24 21:20:52 UTC) #16
Lei Zhang
On 2014/03/24 21:19:41, Greg Billock wrote: > https://codereview.chromium.org/185863003/diff/110001/chrome/browser/media/chrome_midi_permission_context.cc > File chrome/browser/media/chrome_midi_permission_context.cc (right): > > https://codereview.chromium.org/185863003/diff/110001/chrome/browser/media/chrome_midi_permission_context.cc#newcode171 ...
6 years, 9 months ago (2014-03-24 21:26:56 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-24 22:40:29 UTC) #18
commit-bot: I haz the power
Retried try job too often on android_dbg for step(s) slave_steps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_dbg&number=164031
6 years, 9 months ago (2014-03-24 22:40:30 UTC) #19
Greg Billock
The CQ bit was checked by gbillock@chromium.org
6 years, 9 months ago (2014-03-24 23:08:31 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gbillock@chromium.org/185863003/170001
6 years, 9 months ago (2014-03-24 23:10:06 UTC) #21
Greg Billock
On 2014/03/24 23:10:06, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
6 years, 9 months ago (2014-03-24 23:12:38 UTC) #22
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-24 23:44:54 UTC) #23
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=57141
6 years, 9 months ago (2014-03-24 23:44:55 UTC) #24
mkosiba (inactive)
android_webview/ LGTM
6 years, 9 months ago (2014-03-25 11:25:37 UTC) #25
Greg Billock
The CQ bit was checked by gbillock@chromium.org
6 years, 9 months ago (2014-03-25 17:09:00 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gbillock@chromium.org/185863003/170001
6 years, 9 months ago (2014-03-25 17:09:38 UTC) #27
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-25 17:09:51 UTC) #28
commit-bot: I haz the power
Failed to apply patch for content/browser/renderer_host/media/media_stream_dispatcher_host.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 9 months ago (2014-03-25 17:09:52 UTC) #29
Greg Billock
The CQ bit was checked by gbillock@chromium.org
6 years, 9 months ago (2014-03-25 18:44:13 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gbillock@chromium.org/185863003/230001
6 years, 9 months ago (2014-03-25 18:46:59 UTC) #31
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-25 18:53:51 UTC) #32
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_compile_dbg
6 years, 9 months ago (2014-03-25 18:53:55 UTC) #33
Greg Billock
The CQ bit was checked by gbillock@chromium.org
6 years, 9 months ago (2014-03-27 22:31:45 UTC) #34
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gbillock@chromium.org/185863003/230001
6 years, 9 months ago (2014-03-27 22:33:33 UTC) #35
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 23:10:17 UTC) #36
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_compile_dbg
6 years, 9 months ago (2014-03-27 23:10:18 UTC) #37
Greg Billock
The CQ bit was checked by gbillock@chromium.org
6 years, 9 months ago (2014-03-28 15:53:44 UTC) #38
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gbillock@chromium.org/185863003/230001
6 years, 9 months ago (2014-03-28 15:57:09 UTC) #39
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 17:06:10 UTC) #40
commit-bot: I haz the power
Retried try job too often on android_dbg for step(s) slave_steps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_dbg&number=165754
6 years, 9 months ago (2014-03-28 17:06:11 UTC) #41
Greg Billock
The CQ bit was checked by gbillock@chromium.org
6 years, 9 months ago (2014-03-28 17:40:56 UTC) #42
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gbillock@chromium.org/185863003/350001
6 years, 9 months ago (2014-03-28 17:41:41 UTC) #43
commit-bot: I haz the power
6 years, 9 months ago (2014-03-28 20:19:37 UTC) #44
Message was sent while issue was closed. 
Change committed as 260257

Powered by Google App Engine
This is Rietveld 408576698