chrome/browser/media/media_stream_devices_controller.cc - Issue 185863003: [Media] Add user gesture reporting for API calls to midi and media streams.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/media_stream_devices_controller.cc

Issue 185863003: [Media] Add user gesture reporting for API calls to midi and media streams. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix test merge Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/media/media_stream_devices_controller.cc

diff --git a/chrome/browser/media/media_stream_devices_controller.cc b/chrome/browser/media/media_stream_devices_controller.cc

index efde7652f2192c419f95cc2008cf00d2ff24dfec..cbe41d7753eae66a1b09bfc2e772c950332b1984 100644

--- a/chrome/browser/media/media_stream_devices_controller.cc

+++ b/chrome/browser/media/media_stream_devices_controller.cc

@@ -388,8 +388,7 @@ base::string16 MediaStreamDevicesController::GetMessageTextFragment() const {

}

bool MediaStreamDevicesController::HasUserGesture() const {

- // TODO(gbillock): plumb this through

- return false;

+ return request_.user_gesture;

}

GURL MediaStreamDevicesController::GetRequestingHostname() const {

« no previous file with comments | « chrome/browser/media/chrome_midi_permission_context.cc ('k') | chrome/browser/policy/policy_browsertest.cc » ('j') | no next file with comments »