content/browser/renderer_host/media/media_stream_dispatcher_host.cc - Issue 185863003: [Media] Add user gesture reporting for API calls to midi and media streams.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/media/media_stream_dispatcher_host.cc

Issue 185863003: [Media] Add user gesture reporting for API calls to midi and media streams. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix test merge Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/media/media_stream_dispatcher_host.h ('k') | content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/media/media_stream_dispatcher_host.cc

diff --git a/content/browser/renderer_host/media/media_stream_dispatcher_host.cc b/content/browser/renderer_host/media/media_stream_dispatcher_host.cc

index 1708c501993a09bc098153d5816aa943cf43b056..0698e214da83cf6d728806aaf65036d30d205461 100644

--- a/content/browser/renderer_host/media/media_stream_dispatcher_host.cc

+++ b/content/browser/renderer_host/media/media_stream_dispatcher_host.cc

@@ -127,21 +127,23 @@ void MediaStreamDispatcherHost::OnGenerateStream(

int render_view_id,

int page_request_id,

const StreamOptions& components,

- const GURL& security_origin) {

+ const GURL& security_origin,

+ bool user_gesture) {

DVLOG(1) << "MediaStreamDispatcherHost::OnGenerateStream("

<< render_view_id << ", "

<< page_request_id << ", ["

<< " audio:" << components.audio_requested

<< " video:" << components.video_requested

<< " ], "

- << security_origin.spec() << ")";

+ << security_origin.spec()

+ << ", " << user_gesture << ")";

if (!IsURLAllowed(security_origin))

return;

media_stream_manager_->GenerateStream(

this, render_process_id_, render_view_id, salt_callback_,

- page_request_id, components, security_origin);

+ page_request_id, components, security_origin, user_gesture);

}

void MediaStreamDispatcherHost::OnCancelGenerateStream(int render_view_id,