Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 1858583002: Simplify LifecycleNotifier and Observer. (Closed)

Created:
4 years, 8 months ago by sof
Modified:
4 years, 8 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, kinuko+watch, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify LifecycleNotifier and Observer. With Oilpan permanently enabled, let go of some dead code. R=haraken BUG=585328 Committed: https://crrev.com/06346839b9887c101b179bf6ee3a039542d5db93 Cr-Commit-Position: refs/heads/master@{#384897}

Patch Set 1 #

Patch Set 2 : fix unit test compilation #

Patch Set 3 : more removals #

Total comments: 1

Messages

Total messages: 11 (6 generated)
sof
please take a look. https://codereview.chromium.org/1858583002/diff/40001/third_party/WebKit/Source/platform/LifecycleNotifier.h File third_party/WebKit/Source/platform/LifecycleNotifier.h (left): https://codereview.chromium.org/1858583002/diff/40001/third_party/WebKit/Source/platform/LifecycleNotifier.h#oldcode112 third_party/WebKit/Source/platform/LifecycleNotifier.h:112: // FIXME: Oilpan: At the ...
4 years, 8 months ago (2016-04-04 09:47:32 UTC) #2
haraken
LGTM
4 years, 8 months ago (2016-04-04 12:09:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1858583002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1858583002/40001
4 years, 8 months ago (2016-04-04 13:37:05 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-04 13:42:31 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-04 13:43:36 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/06346839b9887c101b179bf6ee3a039542d5db93
Cr-Commit-Position: refs/heads/master@{#384897}

Powered by Google App Engine
This is Rietveld 408576698