Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(735)

Unified Diff: third_party/WebKit/Source/platform/LifecycleObserver.h

Issue 1858583002: Simplify LifecycleNotifier and Observer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: more removals Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/LifecycleObserver.h
diff --git a/third_party/WebKit/Source/platform/LifecycleObserver.h b/third_party/WebKit/Source/platform/LifecycleObserver.h
index 09a9b3dc4d5b07b5309e79996c84a44b63697317..93a364a2ed9bea2ac960d20ad6478d7508b446bc 100644
--- a/third_party/WebKit/Source/platform/LifecycleObserver.h
+++ b/third_party/WebKit/Source/platform/LifecycleObserver.h
@@ -28,7 +28,6 @@
#define LifecycleObserver_h
#include "platform/heap/Handle.h"
-#include "wtf/Assertions.h"
namespace blink {
@@ -37,13 +36,6 @@ class LifecycleObserver : public GarbageCollectedMixin {
public:
using Context = T;
-#if !ENABLE(OILPAN)
- virtual ~LifecycleObserver()
- {
- clearContext();
- }
-#endif
-
DEFINE_INLINE_VIRTUAL_TRACE()
{
visitor->trace(m_lifecycleContext);
@@ -52,7 +44,6 @@ public:
virtual void contextDestroyed() { }
Context* lifecycleContext() const { return m_lifecycleContext; }
- void clearLifecycleContext() { m_lifecycleContext = nullptr; }
protected:
explicit LifecycleObserver(Context* context)

Powered by Google App Engine
This is Rietveld 408576698