Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Side by Side Diff: third_party/WebKit/Source/core/page/PageLifecycleNotifier.cpp

Issue 1858583002: Simplify LifecycleNotifier and Observer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: more removals Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All Rights Reserved. 2 * Copyright (C) 2013 Google Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 15 matching lines...) Expand all
26 26
27 #include "core/page/PageLifecycleNotifier.h" 27 #include "core/page/PageLifecycleNotifier.h"
28 28
29 #include "core/page/PageLifecycleObserver.h" 29 #include "core/page/PageLifecycleObserver.h"
30 30
31 namespace blink { 31 namespace blink {
32 32
33 void PageLifecycleNotifier::notifyPageVisibilityChanged() 33 void PageLifecycleNotifier::notifyPageVisibilityChanged()
34 { 34 {
35 TemporaryChange<IterationType> scope(m_iterating, IteratingOverAll); 35 TemporaryChange<IterationType> scope(m_iterating, IteratingOverAll);
36 #if !ENABLE(OILPAN)
37 // Notifications perform unknown amounts of heap allocations,
38 // which might trigger (conservative) GCs. This will flush out
39 // dead observers, causing the _non-heap_ set be updated. Snapshot
40 // the observers and explicitly check if they're still alive before
41 // notifying.
42 Vector<RawPtr<PageLifecycleObserver>> snapshotOfObservers;
43 copyToVector(m_observers, snapshotOfObservers);
44 for (PageLifecycleObserver* observer : snapshotOfObservers) {
45 if (m_observers.contains(observer))
46 observer->pageVisibilityChanged();
47 }
48 #else
49 for (PageLifecycleObserver* observer : m_observers) 36 for (PageLifecycleObserver* observer : m_observers)
50 observer->pageVisibilityChanged(); 37 observer->pageVisibilityChanged();
51 #endif
52 } 38 }
53 39
54 void PageLifecycleNotifier::notifyDidCommitLoad(LocalFrame* frame) 40 void PageLifecycleNotifier::notifyDidCommitLoad(LocalFrame* frame)
55 { 41 {
56 TemporaryChange<IterationType> scope(m_iterating, IteratingOverAll); 42 TemporaryChange<IterationType> scope(m_iterating, IteratingOverAll);
57 #if !ENABLE(OILPAN)
58 // Notifications perform unknown amounts of heap allocations,
59 // which might trigger (conservative) GCs. This will flush out
60 // dead observers, causing the _non-heap_ set be updated. Snapshot
61 // the observers and explicitly check if they're still alive before
62 // notifying.
63 Vector<RawPtr<PageLifecycleObserver>> snapshotOfObservers;
64 copyToVector(m_observers, snapshotOfObservers);
65 for (PageLifecycleObserver* observer : snapshotOfObservers) {
66 if (m_observers.contains(observer))
67 observer->didCommitLoad(frame);
68 }
69 #else
70 for (PageLifecycleObserver* observer : m_observers) 43 for (PageLifecycleObserver* observer : m_observers)
71 observer->didCommitLoad(frame); 44 observer->didCommitLoad(frame);
72 #endif
73 } 45 }
74 46
75 } // namespace blink 47 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698