Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(965)

Unified Diff: ppapi/native_client/src/trusted/plugin/pnacl_coordinator.h

Issue 185853008: Delete the PNaCl translate thread before deleting object files on surfaway. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: update .h comment Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/native_client/src/trusted/plugin/pnacl_coordinator.h
diff --git a/ppapi/native_client/src/trusted/plugin/pnacl_coordinator.h b/ppapi/native_client/src/trusted/plugin/pnacl_coordinator.h
index 3b533ab5142701b0d72bb62d566dec0e95a28604..321878b9ef7f4c3fa16e17400ced60d91787635a 100644
--- a/ppapi/native_client/src/trusted/plugin/pnacl_coordinator.h
+++ b/ppapi/native_client/src/trusted/plugin/pnacl_coordinator.h
@@ -234,8 +234,8 @@ class PnaclCoordinator: public CallbackSource<FileStreamData> {
int64_t expected_pexe_size_; // Expected download total (-1 if unknown).
// The helper thread used to do translations via SRPC.
- // Keep this last in declaration order to ensure the other variables
- // haven't been destroyed yet when its destructor runs.
+ // It accesses fields of PnaclCoordinator so it must have a
+ // shorter lifetime.
nacl::scoped_ptr<PnaclTranslateThread> translate_thread_;
};
« no previous file with comments | « no previous file | ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698