Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Unified Diff: ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc

Issue 185853008: Delete the PNaCl translate thread before deleting object files on surfaway. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: update .h comment Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/native_client/src/trusted/plugin/pnacl_coordinator.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc
diff --git a/ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc b/ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc
index 64dfdda520a0b69885aab44c6d90b0b767d5e12e..bdef46e78ecec8200cf86a5e1c6a6ab6bf787993 100644
--- a/ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc
+++ b/ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc
@@ -253,6 +253,12 @@ PnaclCoordinator::~PnaclCoordinator() {
plugin_->pp_instance(),
PP_FALSE);
}
+ // Force deleting the translate_thread now. It must be deleted
+ // before any scoped_* fields hanging off of PnaclCoordinator
+ // since the thread may be accessing those fields.
+ // It will also be accessing obj_files_.
+ translate_thread_.reset(NULL);
+ // TODO(jvoung): use base/memory/scoped_vector.h to hold obj_files_.
for (int i = 0; i < num_object_files_opened_; i++) {
delete obj_files_[i];
}
« no previous file with comments | « ppapi/native_client/src/trusted/plugin/pnacl_coordinator.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698