Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Side by Side Diff: ppapi/native_client/src/trusted/plugin/pnacl_coordinator.h

Issue 185853008: Delete the PNaCl translate thread before deleting object files on surfaway. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: update .h comment Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NATIVE_CLIENT_SRC_TRUSTED_PLUGIN_PNACL_COORDINATOR_H_ 5 #ifndef NATIVE_CLIENT_SRC_TRUSTED_PLUGIN_PNACL_COORDINATOR_H_
6 #define NATIVE_CLIENT_SRC_TRUSTED_PLUGIN_PNACL_COORDINATOR_H_ 6 #define NATIVE_CLIENT_SRC_TRUSTED_PLUGIN_PNACL_COORDINATOR_H_
7 7
8 #include <set> 8 #include <set>
9 #include <map> 9 #include <map>
10 #include <vector> 10 #include <vector>
(...skipping 216 matching lines...) Expand 10 before | Expand all | Expand 10 after
227 // was already run/consumed. 227 // was already run/consumed.
228 bool error_already_reported_; 228 bool error_already_reported_;
229 229
230 // State for timing and size information for UMA stats. 230 // State for timing and size information for UMA stats.
231 int64_t pnacl_init_time_; 231 int64_t pnacl_init_time_;
232 int64_t pexe_size_; // Count as we stream -- will converge to pexe size. 232 int64_t pexe_size_; // Count as we stream -- will converge to pexe size.
233 int64_t pexe_bytes_compiled_; // Count as we compile. 233 int64_t pexe_bytes_compiled_; // Count as we compile.
234 int64_t expected_pexe_size_; // Expected download total (-1 if unknown). 234 int64_t expected_pexe_size_; // Expected download total (-1 if unknown).
235 235
236 // The helper thread used to do translations via SRPC. 236 // The helper thread used to do translations via SRPC.
237 // Keep this last in declaration order to ensure the other variables 237 // It accesses fields of PnaclCoordinator so it must have a
238 // haven't been destroyed yet when its destructor runs. 238 // shorter lifetime.
239 nacl::scoped_ptr<PnaclTranslateThread> translate_thread_; 239 nacl::scoped_ptr<PnaclTranslateThread> translate_thread_;
240 }; 240 };
241 241
242 //---------------------------------------------------------------------- 242 //----------------------------------------------------------------------
243 243
244 } // namespace plugin; 244 } // namespace plugin;
245 #endif // NATIVE_CLIENT_SRC_TRUSTED_PLUGIN_PNACL_COORDINATOR_H_ 245 #endif // NATIVE_CLIENT_SRC_TRUSTED_PLUGIN_PNACL_COORDINATOR_H_
OLDNEW
« no previous file with comments | « no previous file | ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698