Delete the PNaCl translate thread before deleting object files on surfaway.

Delete the PNaCl translate thread before deleting object files on surfaway.

Can't currently use base's ScopedVector for obj_files
(instead of manual deletion), because base's [D]CHECK
macros conflict with the NaCl ones that currently
get pulled in.

BUG=348742
TEST= currently manual:
Put a sleep(n) at the right place in the translate
thread and surf away -- observe before and after the patch.

R=teravest@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254872

[teravest, 2014-03-04 15:11:18]

You should update the comment for translate_thread_ in pnacl_coordinator.h.

It currently says:
  // The helper thread used to do translations via SRPC.
  // Keep this last in declaration order to ensure the other variables
  // haven't been destroyed yet when its destructor runs.
  nacl::scoped_ptr<PnaclTranslateThread> translate_thread_;

[jvoung (off chromium), 2014-03-04 16:37:14]

Updated .h comment -- too redundant or okay?

[teravest, 2014-03-04 16:38:21]

lgtm

[jvoung (off chromium), 2014-03-04 16:47:23]

The CQ bit was checked by jvoung@chromium.org

[commit-bot: I haz the power, 2014-03-04 16:48:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jvoung@chromium.org/185853008/20001

[jvoung (off chromium), 2014-03-04 23:10:58]

Committed patchset #2 manually as r254872 (presubmit successful).