third_party/WebKit/Source/core/editing/Position.h - Issue 1858163002: Rename inDocument() to inShadowIncludingDocument()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/Position.h

Issue 1858163002: Rename inDocument() to inShadowIncludingDocument() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/Position.h

diff --git a/third_party/WebKit/Source/core/editing/Position.h b/third_party/WebKit/Source/core/editing/Position.h

index 8b49ae6ea228aaea7124c9ed793780828e75e017..84d9221f6203035db688adf57df1f517ec5788b8 100644

--- a/third_party/WebKit/Source/core/editing/Position.h

+++ b/third_party/WebKit/Source/core/editing/Position.h

@@ -137,11 +137,11 @@ public:

Node* anchorNode() const { return m_anchorNode.get(); }

Document* document() const { return m_anchorNode ? &m_anchorNode->document() : 0; }

- bool inDocument() const { return m_anchorNode && m_anchorNode->inDocument(); }

+ bool inShadowIncludingDocument() const { return m_anchorNode && m_anchorNode->inShadowIncludingDocument(); }

bool isNull() const { return !m_anchorNode; }

bool isNotNull() const { return m_anchorNode; }

- bool isOrphan() const { return m_anchorNode && !m_anchorNode->inDocument(); }

+ bool isOrphan() const { return m_anchorNode && !m_anchorNode->inShadowIncludingDocument(); }

int compareTo(const PositionTemplate<Strategy>&) const;