Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1149)

Unified Diff: third_party/WebKit/Source/core/editing/PendingSelection.cpp

Issue 1858163002: Rename inDocument() to inShadowIncludingDocument() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/PendingSelection.cpp
diff --git a/third_party/WebKit/Source/core/editing/PendingSelection.cpp b/third_party/WebKit/Source/core/editing/PendingSelection.cpp
index 7e28d9fdeef37e18f0bcfaf5aeef2330bcbc79e7..02afe9e71686bba20f36d895c9b836a3013cc6ef 100644
--- a/third_party/WebKit/Source/core/editing/PendingSelection.cpp
+++ b/third_party/WebKit/Source/core/editing/PendingSelection.cpp
@@ -44,13 +44,13 @@ const VisibleSelection& PendingSelection::visibleSelection() const
static bool isSelectionInDocument(const VisibleSelectionInFlatTree& visibleSelection, const Document& document)
{
const PositionInFlatTree& start = visibleSelection.start();
- if (start.isNotNull() && (!start.inDocument() || start.document() != document))
+ if (start.isNotNull() && (!start.inShadowIncludingDocument() || start.document() != document))
return false;
const PositionInFlatTree& end = visibleSelection.end();
- if (end.isNotNull() && (!end.inDocument() || end.document() != document))
+ if (end.isNotNull() && (!end.inShadowIncludingDocument() || end.document() != document))
return false;
const PositionInFlatTree extent = visibleSelection.extent();
- if (extent.isNotNull() && (!extent.inDocument() || extent.document() != document))
+ if (extent.isNotNull() && (!extent.inShadowIncludingDocument() || extent.document() != document))
return false;
return true;
}
« no previous file with comments | « third_party/WebKit/Source/core/editing/FrameSelection.cpp ('k') | third_party/WebKit/Source/core/editing/Position.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698