third_party/WebKit/Source/core/editing/VisibleSelection.cpp - Issue 1858163002: Rename inDocument() to inShadowIncludingDocument()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/VisibleSelection.cpp

Issue 1858163002: Rename inDocument() to inShadowIncludingDocument() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/VisibleSelection.cpp

diff --git a/third_party/WebKit/Source/core/editing/VisibleSelection.cpp b/third_party/WebKit/Source/core/editing/VisibleSelection.cpp

index 40e5b828ab85cf7a908062e4a4bb02cb823173c4..de26047c66771bdc733d1fc0bcf8e91d9a3aafb5 100644

--- a/third_party/WebKit/Source/core/editing/VisibleSelection.cpp

+++ b/third_party/WebKit/Source/core/editing/VisibleSelection.cpp

@@ -827,7 +827,7 @@ void VisibleSelectionTemplate<Strategy>::didChange()

template <typename Strategy>

static bool isValidPosition(const PositionTemplate<Strategy>& position)

{

- if (!position.inDocument())

+ if (!position.inShadowIncludingDocument())

return false;

if (!position.isOffsetInAnchor())