Record parser blocking time for scripts inserted via doc.write

Record amount of time the parser is blocked on script load, for scripts
inserted via document.write. This is an important metric for Project NeverIdle:
https://docs.google.com/document/d/1vUqy6uke6U1nalT6qlHbzl1LaXPHn9fLSXxGgUbMAxA/edit

BUG=588724
Committed: https://crrev.com/cdaf10433011efe4c83c569b29e7957a0959dd3c
Cr-Commit-Position: refs/heads/master@{#385842}

[Charlie Harrison, 2016-04-04 19:00:16]

csharrison@chromium.org changed reviewers:
+ csharrison@chromium.org

[Charlie Harrison, 2016-04-04 19:00:17]

Looks good!

https://codereview.chromium.org/1857903002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/parser/HTMLScriptRunner.cpp (right):

https://codereview.chromium.org/1857903002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/parser/HTMLScriptRunner.cpp:220:
DocumentParserTiming::from(*m_document).recordParserBlockedOnScriptLoadDuration(monotonicallyIncreasingTime()
- scriptParserBlockingTime, scriptLoader->createdDuringDocumentWrite());
You can add my CL as a dependent so trybots, etc can run.

[jkarlin, 2016-04-04 19:10:58]

jkarlin@chromium.org changed reviewers:
+ jkarlin@chromium.org

[jkarlin, 2016-04-04 19:10:59]

This will be great to have. Looks good.

[Bryan McQuade, 2016-04-04 21:03:27]

Description was changed from

==========
Record amount of time the parser is blocked on script load, for scripts
inserted via document.write.

BUG=588724
==========

to

==========
Record amount of time the parser is blocked on script load, for scripts
inserted via document.write. This is an important metric for Project NeverIdle:
https://docs.google.com/document/d/1vUqy6uke6U1nalT6qlHbzl1LaXPHn9fLSXxGgUbMA...

BUG=588724
==========

[Bryan McQuade, 2016-04-04 21:26:50]

bmcquade@chromium.org changed reviewers:
+ japhet@chromium.org, kouhei@chromium.org

[Bryan McQuade, 2016-04-04 21:27:29]

kouhei, PTAL for HTMLScriptRunner etc
japhet, PTAL for blink public
csharrison, jkarlin, PTAL for overall change

[Charlie Harrison, 2016-04-04 21:33:26]

https://codereview.chromium.org/1857903002/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/dom/DocumentParserTiming.h (right):

https://codereview.chromium.org/1857903002/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/dom/DocumentParserTiming.h:67: double
parserBlockedOnScriptLoadFromDocumentWriteDuration() const { return
m_parserBlockedOnScriptLoadFromDocumentWriteDuration; }
Can you include a comment that this is a lower bound, because the mechanism for
determining if a script was written by document.write sometimes has false
negatives?

[kouhei (in TOK), 2016-04-05 13:22:29]

lgtm

[Bryan McQuade, 2016-04-05 15:14:11]

Thanks for opening the bug! Comment added.

https://codereview.chromium.org/1857903002/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/dom/DocumentParserTiming.h (right):

https://codereview.chromium.org/1857903002/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/dom/DocumentParserTiming.h:67: double
parserBlockedOnScriptLoadFromDocumentWriteDuration() const { return
m_parserBlockedOnScriptLoadFromDocumentWriteDuration; }
On 2016/04/04 at 21:33:26, csharrison wrote:
> Can you include a comment that this is a lower bound, because the mechanism
for determining if a script was written by document.write sometimes has false
negatives?

Done.

[Charlie Harrison, 2016-04-06 13:33:40]

lgtm

[Nate Chapin, 2016-04-07 16:29:31]

LGTM

https://codereview.chromium.org/1857903002/diff/160001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/dom/DocumentParserTiming.h (right):

https://codereview.chromium.org/1857903002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/dom/DocumentParserTiming.h:48: // script causing
blocking was inserted via document.write. This may be
I'm an old-timey WebKit curmudgeon, so I think this addition to the comment is
self-obvious and therefore unnecessary. I recognize it's more in line with
chromium style, but that doesn't mean I have to like it! :(

[Bryan McQuade, 2016-04-07 17:36:13]

On 2016/04/07 at 16:29:31, japhet wrote:
> LGTM
> 
>
https://codereview.chromium.org/1857903002/diff/160001/third_party/WebKit/Sou...
> File third_party/WebKit/Source/core/dom/DocumentParserTiming.h (right):
> 
>
https://codereview.chromium.org/1857903002/diff/160001/third_party/WebKit/Sou...
> third_party/WebKit/Source/core/dom/DocumentParserTiming.h:48: // script
causing blocking was inserted via document.write. This may be
> I'm an old-timey WebKit curmudgeon, so I think this addition to the comment is
self-obvious and therefore unnecessary. I recognize it's more in line with
chromium style, but that doesn't mean I have to like it! :(

Good point, actually. :) You are right that this is a bit obvious. I probably
tend to over comment. I'll leave this one as is but try to focus on the less
obvious aspects of things when writing comments going forward.

[Bryan McQuade, 2016-04-07 17:36:16]

The CQ bit was checked by bmcquade@chromium.org

[Bryan McQuade, 2016-04-07 17:36:17]

The patchset sent to the CQ was uploaded after l-g-t-m from kouhei@chromium.org
Link to the patchset: https://codereview.chromium.org/1857903002/#ps160001
(title: " ")

[commit-bot: I haz the power, 2016-04-07 17:36:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1857903002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1857903002/160001

[commit-bot: I haz the power, 2016-04-07 19:47:19]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2016-04-07 19:48:18]

Description was changed from

==========
Record amount of time the parser is blocked on script load, for scripts
inserted via document.write. This is an important metric for Project NeverIdle:
https://docs.google.com/document/d/1vUqy6uke6U1nalT6qlHbzl1LaXPHn9fLSXxGgUbMA...

BUG=588724
==========

to

==========
Record amount of time the parser is blocked on script load, for scripts
inserted via document.write. This is an important metric for Project NeverIdle:
https://docs.google.com/document/d/1vUqy6uke6U1nalT6qlHbzl1LaXPHn9fLSXxGgUbMA...

BUG=588724

Committed: https://crrev.com/cdaf10433011efe4c83c569b29e7957a0959dd3c
Cr-Commit-Position: refs/heads/master@{#385842}
==========

[commit-bot: I haz the power, 2016-04-07 19:48:19]

Patchset 9 (id:??) landed as
https://crrev.com/cdaf10433011efe4c83c569b29e7957a0959dd3c
Cr-Commit-Position: refs/heads/master@{#385842}