third_party/WebKit/Source/core/html/parser/HTMLScriptRunner.cpp - Issue 1857903002: Record parser blocking time for scripts inserted via doc.write

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/parser/HTMLScriptRunner.cpp

Issue 1857903002: Record parser blocking time for scripts inserted via doc.write (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/dom/DocumentParserTiming.h ('K') | « third_party/WebKit/Source/core/dom/DocumentParserTiming.cpp ('k') | third_party/WebKit/Source/core/timing/PerformanceTiming.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/parser/HTMLScriptRunner.cpp

diff --git a/third_party/WebKit/Source/core/html/parser/HTMLScriptRunner.cpp b/third_party/WebKit/Source/core/html/parser/HTMLScriptRunner.cpp

index 6b2b0eb1e27366951dfa08c16343c91b0a581e2c..4ca64b9c82f4220ea9fda2c6f643069ac809ab6a 100644

--- a/third_party/WebKit/Source/core/html/parser/HTMLScriptRunner.cpp

+++ b/third_party/WebKit/Source/core/html/parser/HTMLScriptRunner.cpp

@@ -217,7 +217,7 @@ void HTMLScriptRunner::executePendingScriptAndDispatchEvent(PendingScript* pendi

} else {

ASSERT(isExecutingScript());

if (scriptParserBlockingTime > 0.0) {

- DocumentParserTiming::from(*m_document).recordParserBlockedOnScriptLoadDuration(monotonicallyIncreasingTime() - scriptParserBlockingTime);

+ DocumentParserTiming::from(*m_document).recordParserBlockedOnScriptLoadDuration(monotonicallyIncreasingTime() - scriptParserBlockingTime, scriptLoader->wasCreatedDuringDocumentWrite());

}

if (!doExecuteScript(element.get(), sourceCode, scriptStartPosition)) {

scriptLoader->dispatchErrorEvent();