Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1857643003: Revert of Migrate tsmon protos to proto3 (Closed)

Created:
4 years, 8 months ago by dsansome
Modified:
4 years, 8 months ago
Reviewers:
iannucci
CC:
agable, andrew.wang, chromium-reviews, infra-reviews+luci-go_chromium.org, M-A Ruel, tandrii+luci-go_chromium.org, todd
Base URL:
git@github.com:luci/luci-go.git@master
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Revert of Migrate tsmon protos to proto3 (patchset #1 id:1 of https://codereview.chromium.org/1854583002/ ) Reason for revert: On second thoughts this can't possibly work because the type of metric in a MetricsData message is determined by the presence of optional fields. Original issue's description: > Migrate tsmon protos to proto3 > > BUG= > > Committed: https://github.com/luci/luci-go/commit/f9ccd6e92419d931bfe3bd88b2f62ad1e9db2e82 TBR=iannucci@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://github.com/luci/luci-go/commit/6f4458e3a06ec1a47e4712ea711a2cced50db9c2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+825 lines, -296 lines) Patch
M appengine/tsmon/global_callback_test.go View 2 chunks +2 lines, -1 line 0 comments Download
M appengine/tsmon/middleware.go View 4 chunks +9 lines, -8 lines 0 comments Download
M appengine/tsmon/middleware_test.go View 2 chunks +2 lines, -1 line 0 comments Download
M appengine/tsmon/standardmetrics_test.go View 2 chunks +2 lines, -1 line 0 comments Download
M common/tsmon/context.go View 2 chunks +2 lines, -1 line 0 comments Download
M common/tsmon/field/field.go View 2 chunks +7 lines, -5 lines 0 comments Download
M common/tsmon/field/field_test.go View 4 chunks +11 lines, -9 lines 0 comments Download
M common/tsmon/flush_test.go View 2 chunks +4 lines, -1 line 0 comments Download
M common/tsmon/metric/metric_test.go View 2 chunks +2 lines, -1 line 0 comments Download
M common/tsmon/monitor/acq.go View 5 chunks +24 lines, -23 lines 0 comments Download
M common/tsmon/monitor/acq_test.go View 14 chunks +72 lines, -71 lines 0 comments Download
M common/tsmon/store/inmemory_test.go View 2 chunks +2 lines, -1 line 0 comments Download
M common/tsmon/store/testing.go View 7 chunks +11 lines, -11 lines 0 comments Download
M common/tsmon/target/target.go View 3 chunks +33 lines, -33 lines 0 comments Download
M common/tsmon/ts_mon_proto/acquisition_network_device.proto View 1 chunk +9 lines, -7 lines 0 comments Download
M common/tsmon/ts_mon_proto/acquisition_network_device.pb.go View 1 chunk +111 lines, -10 lines 0 comments Download
M common/tsmon/ts_mon_proto/acquisition_task.proto View 1 chunk +8 lines, -6 lines 0 comments Download
M common/tsmon/ts_mon_proto/acquisition_task.pb.go View 1 chunk +97 lines, -9 lines 0 comments Download
M common/tsmon/ts_mon_proto/metrics.proto View 4 chunks +32 lines, -33 lines 0 comments Download
M common/tsmon/ts_mon_proto/metrics.pb.go View 8 chunks +384 lines, -63 lines 0 comments Download
M common/tsmon/ts_mon_proto/proto-gen.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
dsansome
Created Revert of Migrate tsmon protos to proto3
4 years, 8 months ago (2016-04-04 03:59:56 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1857643003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1857643003/1
4 years, 8 months ago (2016-04-04 04:00:12 UTC) #2
commit-bot: I haz the power
4 years, 8 months ago (2016-04-04 04:00:23 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/6f4458e3a06ec1a47e4712ea711a2cced50db9c2

Powered by Google App Engine
This is Rietveld 408576698