appengine/tsmon/middleware_test.go - Issue 1857643003: Revert of Migrate tsmon protos to proto3

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/tsmon/middleware_test.go

Issue 1857643003: Revert of Migrate tsmon protos to proto3 (Closed) Base URL: git@github.com:luci/luci-go.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: appengine/tsmon/middleware_test.go

diff --git a/appengine/tsmon/middleware_test.go b/appengine/tsmon/middleware_test.go

index d885e341293a79cfeb70235bbd0d04301b316168..a37c728f3433e0c622c74ff0ac78d0f6dba21ff0 100644

--- a/appengine/tsmon/middleware_test.go

+++ b/appengine/tsmon/middleware_test.go

@@ -10,6 +10,7 @@

"testing"

"time"

+ "github.com/golang/protobuf/proto"

"github.com/julienschmidt/httprouter"

"github.com/luci/gae/service/datastore"

"github.com/luci/luci-go/common/tsmon"

@@ -104,7 +105,7 @@

// Override the TaskNum here - it's created just before this handler runs

// and used just after.

tar := tsmon.Store(c).DefaultTarget().(*target.Task)

- tar.TaskNum = 0

+ tar.TaskNum = proto.Int32(int32(0))

tsmon.Store(c).SetDefaultTarget(tar)

})(c, rec, &http.Request{}, nil)

So(rec.Code, ShouldEqual, http.StatusOK)

« no previous file with comments | « appengine/tsmon/middleware.go ('k') | appengine/tsmon/standardmetrics_test.go » ('j') | no next file with comments »