common/tsmon/store/inmemory_test.go - Issue 1857643003: Revert of Migrate tsmon protos to proto3

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: common/tsmon/store/inmemory_test.go

Issue 1857643003: Revert of Migrate tsmon protos to proto3 (Closed) Base URL: git@github.com:luci/luci-go.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: common/tsmon/store/inmemory_test.go

diff --git a/common/tsmon/store/inmemory_test.go b/common/tsmon/store/inmemory_test.go

index d466f188b5db38947f4f5b0389f677146f1b64df..3149e5a4012356a37a2d4f45022b1b74253eda50 100644

--- a/common/tsmon/store/inmemory_test.go

+++ b/common/tsmon/store/inmemory_test.go

@@ -6,6 +6,7 @@

import (

"testing"

+ "github.com/golang/protobuf/proto"

"github.com/luci/luci-go/common/tsmon/target"

"golang.org/x/net/context"

)

@@ -14,7 +15,7 @@

ctx := context.Background()

RunStoreImplementationTests(t, ctx, TestOptions{

Factory: func() Store {

- return NewInMemory(&target.Task{ServiceName: "default target"})

+ return NewInMemory(&target.Task{ServiceName: proto.String("default target")})

RegistrationFinished: func(Store) {},

GetNumRegisteredMetrics: func(s Store) int {

« no previous file with comments | « common/tsmon/monitor/acq_test.go ('k') | common/tsmon/store/testing.go » ('j') | no next file with comments »