components/page_load_metrics/common/page_load_timing.h - Issue 1857443002: Plumb experiment flags through page_load_metrics and add a new observer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/page_load_metrics/common/page_load_timing.h

Issue 1857443002: Plumb experiment flags through page_load_metrics and add a new observer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@page_load_experiments

Patch Set: No need to add Default group to variation config Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/page_load_metrics/browser/metrics_web_contents_observer.cc ('K') | « components/page_load_metrics/common/page_load_metrics_messages.h ('k') | components/page_load_metrics/common/page_load_timing.cc » ('j') | components/page_load_metrics/renderer/page_timing_metrics_sender.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/page_load_metrics/common/page_load_timing.h

diff --git a/components/page_load_metrics/common/page_load_timing.h b/components/page_load_metrics/common/page_load_timing.h

index 3b1df5e364205d7066b106e701f5cbcd88cdca6e..3cc52c893f77c32d73fd4b37c176c465054b4caa 100644

--- a/components/page_load_metrics/common/page_load_timing.h

+++ b/components/page_load_metrics/common/page_load_timing.h

@@ -6,6 +6,7 @@

#define COMPONENTS_PAGE_LOAD_METRICS_COMMON_PAGE_LOAD_TIMING_H_

#include "base/time/time.h"

+#include "third_party/WebKit/public/platform/WebLoadingBehaviorFlag.h"

namespace page_load_metrics {

@@ -66,6 +67,13 @@ struct PageLoadTiming {

// page_load_metrics_messages.h, and IsEmpty().

};

+struct PageLoadMetadata {

+ PageLoadMetadata();

+ bool operator==(const PageLoadMetadata& other) const;

+ // These are packed blink::WebLoadingBehaviorFlag enums.

+ int behavior_flags = blink::WebLoadingBehaviorNone;

+};

} // namespace page_load_metrics

#endif // COMPONENTS_PAGE_LOAD_METRICS_COMMON_PAGE_LOAD_TIMING_H_