components/page_load_metrics/common/page_load_metrics_messages.h - Issue 1857443002: Plumb experiment flags through page_load_metrics and add a new observer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/page_load_metrics/common/page_load_metrics_messages.h

Issue 1857443002: Plumb experiment flags through page_load_metrics and add a new observer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@page_load_experiments

Patch Set: No need to add Default group to variation config Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/page_load_metrics/browser/metrics_web_contents_observer.cc ('K') | « components/page_load_metrics/browser/page_load_metrics_observer.cc ('k') | components/page_load_metrics/common/page_load_timing.h » ('j') | components/page_load_metrics/renderer/page_timing_metrics_sender.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/page_load_metrics/common/page_load_metrics_messages.h

diff --git a/components/page_load_metrics/common/page_load_metrics_messages.h b/components/page_load_metrics/common/page_load_metrics_messages.h

index 71e8c70b317dd31be3d7a626b36f0ea753eb61c3..6184345c26d4969d2a1911e47d0b8dd31375de0e 100644

--- a/components/page_load_metrics/common/page_load_metrics_messages.h

+++ b/components/page_load_metrics/common/page_load_metrics_messages.h

@@ -28,7 +28,12 @@ IPC_STRUCT_TRAITS_BEGIN(page_load_metrics::PageLoadTiming)

IPC_STRUCT_TRAITS_MEMBER(parse_blocked_on_script_load_duration)

IPC_STRUCT_TRAITS_END()

+IPC_STRUCT_TRAITS_BEGIN(page_load_metrics::PageLoadMetadata)

+ IPC_STRUCT_TRAITS_MEMBER(behavior_flags)

+IPC_STRUCT_TRAITS_END()

// Sent from renderer to browser process when the PageLoadTiming for the

// associated frame changed.

-IPC_MESSAGE_ROUTED1(PageLoadMetricsMsg_TimingUpdated,

- page_load_metrics::PageLoadTiming)

+IPC_MESSAGE_ROUTED2(PageLoadMetricsMsg_TimingUpdated,

+ page_load_metrics::PageLoadTiming,

+ page_load_metrics::PageLoadMetadata);