Plumb experiment flags through page_load_metrics and add a new observer

components/page_load_metrics/renderer/page_timing_metrics_sender.cc

Index: components/page_load_metrics/renderer/page_timing_metrics_sender.cc
diff --git a/components/page_load_metrics/renderer/page_timing_metrics_sender.cc b/components/page_load_metrics/renderer/page_timing_metrics_sender.cc
index 52d87704aa3ee2ed79f2be6d7ff2acddf4f2e967..b83bbc2ab59168e0fa84b5d456c3349e320a516b 100644
--- a/components/page_load_metrics/renderer/page_timing_metrics_sender.cc
+++ b/components/page_load_metrics/renderer/page_timing_metrics_sender.cc
@@ -23,7 +23,8 @@ PageTimingMetricsSender::PageTimingMetricsSender(IPC::Sender* ipc_sender,
                                                  scoped_ptr<base::Timer> timer)
     : ipc_sender_(ipc_sender),
       routing_id_(routing_id),
-      timer_(std::move(timer)) {}
+      timer_(std::move(timer)),
+      metadata_(PageLoadMetadata()) {}
 
 // On destruction, we want to send any data we have if we have a timer
 // currently running (and thus are talking to a browser process)
@@ -34,6 +35,11 @@ PageTimingMetricsSender::~PageTimingMetricsSender() {
   }
 }
 
+void PageTimingMetricsSender::DidObserveLoadingBehavior(
+    blink::WebLoadingBehaviorFlag behavior) {
+  metadata_.behavior_flags |= behavior;

[Bryan McQuade, 2016/04/11 20:18:47]

should we also start the send timer here if it's not already started? maybe we
can factor the logic for starting the timer into a helper and call it from this
method and from the end of Send(const PageLoadTiming&); otherwise, if a behavior
is observed shortly after the last timing update gets sent, we'll never get the
behavior update on the browser side.

if we do this, we might also add a check to see if the existing flag is already
set in the metadata, and return early if so, to avoid sending updates when no
new state has been observed.

[Charlie Harrison, 2016/04/12 15:18:50]

Done.

+}
+
 void PageTimingMetricsSender::Send(const PageLoadTiming& timing) {
   if (timing == last_timing_)
     return;
@@ -55,8 +61,8 @@ void PageTimingMetricsSender::Send(const PageLoadTiming& timing) {
 }
 
 void PageTimingMetricsSender::SendNow() {
-  ipc_sender_->Send(
-      new PageLoadMetricsMsg_TimingUpdated(routing_id_, last_timing_));
+  ipc_sender_->Send(new PageLoadMetricsMsg_TimingUpdated(
+      routing_id_, last_timing_, metadata_));
 }
 
 }  // namespace page_load_metrics