components/page_load_metrics/renderer/metrics_render_frame_observer.h - Issue 1857443002: Plumb experiment flags through page_load_metrics and add a new observer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/page_load_metrics/renderer/metrics_render_frame_observer.h

Issue 1857443002: Plumb experiment flags through page_load_metrics and add a new observer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@page_load_experiments

Patch Set: remove todo and fix up a test script Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/page_load_metrics/common/page_load_timing.cc ('k') | components/page_load_metrics/renderer/metrics_render_frame_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/page_load_metrics/renderer/metrics_render_frame_observer.h

diff --git a/components/page_load_metrics/renderer/metrics_render_frame_observer.h b/components/page_load_metrics/renderer/metrics_render_frame_observer.h

index 258303bc1e1709d5c78520854112aa46902ece4b..243e9ef4081eea7db6e7f0d514c2bce846af525b 100644

--- a/components/page_load_metrics/renderer/metrics_render_frame_observer.h

+++ b/components/page_load_metrics/renderer/metrics_render_frame_observer.h

@@ -9,6 +9,7 @@

#include "base/memory/scoped_ptr.h"

#include "components/page_load_metrics/common/page_load_timing.h"

#include "content/public/renderer/render_frame_observer.h"

+#include "third_party/WebKit/public/platform/WebLoadingBehaviorFlag.h"

namespace base {

class Timer;

@@ -27,6 +28,8 @@ class MetricsRenderFrameObserver : public content::RenderFrameObserver {

// RenderFrameObserver implementation

void DidChangePerformanceTiming() override;

+ void DidObserveLoadingBehavior(

+ blink::WebLoadingBehaviorFlag behavior) override;

void DidCommitProvisionalLoad(bool is_new_navigation,

bool is_same_page_navigation) override;