components/page_load_metrics/common/page_load_timing.cc - Issue 1857443002: Plumb experiment flags through page_load_metrics and add a new observer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/page_load_metrics/common/page_load_timing.cc

Issue 1857443002: Plumb experiment flags through page_load_metrics and add a new observer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@page_load_experiments

Patch Set: remove todo and fix up a test script Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/page_load_metrics/common/page_load_timing.h ('k') | components/page_load_metrics/renderer/metrics_render_frame_observer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/page_load_metrics/common/page_load_timing.cc

diff --git a/components/page_load_metrics/common/page_load_timing.cc b/components/page_load_metrics/common/page_load_timing.cc

index 7c368204551f40d17cc50dbd3d55f22e85aab254..1c3de6553a7fe927a0490b247342d188f7ae60a2 100644

--- a/components/page_load_metrics/common/page_load_timing.cc

+++ b/components/page_load_metrics/common/page_load_timing.cc

@@ -41,4 +41,10 @@ bool PageLoadTiming::IsEmpty() const {

parse_blocked_on_script_load_from_document_write_duration.is_zero();

}

+PageLoadMetadata::PageLoadMetadata() {}

+bool PageLoadMetadata::operator==(const PageLoadMetadata& other) const {

+ return behavior_flags == other.behavior_flags;

} // namespace page_load_metrics