components/page_load_metrics/renderer/metrics_render_frame_observer.cc - Issue 1857443002: Plumb experiment flags through page_load_metrics and add a new observer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/page_load_metrics/renderer/metrics_render_frame_observer.cc

Issue 1857443002: Plumb experiment flags through page_load_metrics and add a new observer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@page_load_experiments

Patch Set: remove todo and fix up a test script Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/page_load_metrics/renderer/metrics_render_frame_observer.h ('k') | components/page_load_metrics/renderer/metrics_render_frame_observer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/page_load_metrics/renderer/metrics_render_frame_observer.cc

diff --git a/components/page_load_metrics/renderer/metrics_render_frame_observer.cc b/components/page_load_metrics/renderer/metrics_render_frame_observer.cc

index 237c99cc6b35c8e15dcea21be4c4610dc011a9cb..260d3b6285d48c68a63ce22b127e9b70890555ad 100644

--- a/components/page_load_metrics/renderer/metrics_render_frame_observer.cc

+++ b/components/page_load_metrics/renderer/metrics_render_frame_observer.cc

@@ -39,6 +39,12 @@ void MetricsRenderFrameObserver::DidChangePerformanceTiming() {

SendMetrics();

}

+void MetricsRenderFrameObserver::DidObserveLoadingBehavior(

+ blink::WebLoadingBehaviorFlag behavior) {

+ DCHECK(page_timing_metrics_sender_);

+ page_timing_metrics_sender_->DidObserveLoadingBehavior(behavior);

void MetricsRenderFrameObserver::DidCommitProvisionalLoad(

bool is_new_navigation,

bool is_same_page_navigation) {