Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 185743002: Make analyze-all imply analyze-only. (Closed)

Created:
6 years, 9 months ago by Johnni Winther
Modified:
6 years, 9 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Make analyze-all imply analyze-only. BUG=http://dartbug.com/17115 R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=33475

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -34 lines) Patch
M sdk/lib/_internal/compiler/implementation/compiler.dart View 3 chunks +7 lines, -5 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/dart2js.dart View 18 chunks +55 lines, -25 lines 2 comments Download
M sdk/lib/_internal/compiler/implementation/scanner/scanner_task.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/source_file_provider.dart View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Johnni Winther
6 years, 9 months ago (2014-03-07 12:08:58 UTC) #1
floitsch
LGTM. https://codereview.chromium.org/185743002/diff/1/sdk/lib/_internal/compiler/implementation/dart2js.dart File sdk/lib/_internal/compiler/implementation/dart2js.dart (right): https://codereview.chromium.org/185743002/diff/1/sdk/lib/_internal/compiler/implementation/dart2js.dart#newcode352 sdk/lib/_internal/compiler/implementation/dart2js.dart:352: if (analyzeAll) { *nit*: 'if' on one line.
6 years, 9 months ago (2014-03-07 14:03:35 UTC) #2
Johnni Winther
https://codereview.chromium.org/185743002/diff/1/sdk/lib/_internal/compiler/implementation/dart2js.dart File sdk/lib/_internal/compiler/implementation/dart2js.dart (right): https://codereview.chromium.org/185743002/diff/1/sdk/lib/_internal/compiler/implementation/dart2js.dart#newcode352 sdk/lib/_internal/compiler/implementation/dart2js.dart:352: if (analyzeAll) { On 2014/03/07 14:03:35, floitsch wrote: > ...
6 years, 9 months ago (2014-03-10 07:03:07 UTC) #3
Johnni Winther
6 years, 9 months ago (2014-03-10 07:11:10 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 manually as r33475 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698