Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(751)

Unified Diff: sdk/lib/_internal/compiler/implementation/compiler.dart

Issue 185743002: Make analyze-all imply analyze-only. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/compiler.dart
diff --git a/sdk/lib/_internal/compiler/implementation/compiler.dart b/sdk/lib/_internal/compiler/implementation/compiler.dart
index 3409a8ea79de78190b5a5bd11ea334aa1bb7ac46..81f63aff010ca7ce01c362ed89056b536195bb62 100644
--- a/sdk/lib/_internal/compiler/implementation/compiler.dart
+++ b/sdk/lib/_internal/compiler/implementation/compiler.dart
@@ -613,7 +613,7 @@ abstract class Compiler implements DiagnosticListener {
this.enableNativeLiveTypeAnalysis: false,
bool emitJavaScript: true,
bool generateSourceMap: true,
- this.analyzeAllFlag: false,
+ bool analyzeAllFlag: false,
bool analyzeOnly: false,
bool analyzeSignaturesOnly: false,
this.preserveComments: false,
@@ -625,8 +625,10 @@ abstract class Compiler implements DiagnosticListener {
this.hidePackageWarnings: false,
outputProvider,
List<String> strips: const []})
- : this.analyzeOnly = analyzeOnly || analyzeSignaturesOnly,
+ : this.analyzeOnly =
+ analyzeOnly || analyzeSignaturesOnly || analyzeAllFlag,
this.analyzeSignaturesOnly = analyzeSignaturesOnly,
+ this.analyzeAllFlag = analyzeAllFlag,
this.outputProvider = (outputProvider == null)
? NullSink.outputProvider
: outputProvider {
@@ -1011,16 +1013,16 @@ abstract class Compiler implements DiagnosticListener {
return scanBuiltinLibraries().then((_) {
if (librariesToAnalyzeWhenRun != null) {
return Future.forEach(librariesToAnalyzeWhenRun, (libraryUri) {
- log('analyzing $libraryUri ($buildId)');
+ log('Analyzing $libraryUri ($buildId)');
return libraryLoader.loadLibrary(libraryUri, null, libraryUri);
});
}
}).then((_) {
if (uri != null) {
if (analyzeOnly) {
- log('analyzing $uri ($buildId)');
+ log('Analyzing $uri ($buildId)');
} else {
- log('compiling $uri ($buildId)');
+ log('Compiling $uri ($buildId)');
}
return libraryLoader.loadLibrary(uri, null, uri)
.then((LibraryElement library) {

Powered by Google App Engine
This is Rietveld 408576698