Include USB device version in chrome.usb.Device fields.

Include USB device version in chrome.usb.Device fields.

This field is sometimes necessary to determine the protocol supported by
a device as it may change from one version of a device with the same
vendor and product ID pair to the next.

While plumbing this through //device/usb this patch also adds a number
of other device descriptor fields that are exposed through the Mojo
interface but weren't actually hooked up.

BUG=598825
TBR=yurys@chromium.org

Committed: https://crrev.com/a8a7407bab1e16cf519cb84eb73eb3c030f87528
Cr-Commit-Position: refs/heads/master@{#385617}

[Reilly Grant (use Gerrit), 2016-04-04 23:16:23]

Patchset #1 (id:1) has been deleted

[Reilly Grant (use Gerrit), 2016-04-04 23:17:47]

reillyg@chromium.org changed reviewers:
+ asargent@chromium.org, yurys@chromium.org

[Reilly Grant (use Gerrit), 2016-04-04 23:17:48]

asargent@, for //extensions and //device.
yurys@, for //chrome/browser/devtools

[yurys, 2016-04-04 23:52:13]

Description was changed from

==========
Include USB device version in chrome.usb.Device fields.

This field is sometimes necessary to determine the protocol supported by
a device as it may change from one version of a device with the same
vendor and product ID pair to the next.

While plumbing this through //device/usb this patch also adds a number
of other device descriptor fields that are exposed through the Mojo
interface but weren't actually hooked up.

BUG=598825
==========

to

==========
Include USB device version in chrome.usb.Device fields.

This field is sometimes necessary to determine the protocol supported by
a device as it may change from one version of a device with the same
vendor and product ID pair to the next.

While plumbing this through //device/usb this patch also adds a number
of other device descriptor fields that are exposed through the Mojo
interface but weren't actually hooked up.

BUG=598825
==========

[yurys, 2016-04-04 23:52:13]

yurys@chromium.org changed reviewers:
+ dgozman@chromium.org
- yurys@chromium.org

[asargent_no_longer_on_chrome, 2016-04-04 23:52:27]

asargent@chromium.org changed reviewers:
+ yurys@chromium.org
- dgozman@chromium.org

[asargent_no_longer_on_chrome, 2016-04-04 23:52:27]

asargent@chromium.org changed reviewers:
+ yurys@chromium.org
- dgozman@chromium.org

[asargent_no_longer_on_chrome, 2016-04-04 23:52:28]

//device and //extensions lgtm

https://codereview.chromium.org/1857033002/diff/20001/device/usb/mock_usb_dev...
File device/usb/mock_usb_device.cc (right):

https://codereview.chromium.org/1857033002/diff/20001/device/usb/mock_usb_dev...
device/usb/mock_usb_device.cc:22: 0xff,
optional: consider adding comments with the field names next to the test values
to make it easier for readers, e.g.

UsbDevice(0x0200,  /* usb_version */
          0xff,    /* device_class */ 
... etc.


(down below too)

[asargent_no_longer_on_chrome, 2016-04-04 23:52:28]

//device and //extensions lgtm

https://codereview.chromium.org/1857033002/diff/20001/device/usb/mock_usb_dev...
File device/usb/mock_usb_device.cc (right):

https://codereview.chromium.org/1857033002/diff/20001/device/usb/mock_usb_dev...
device/usb/mock_usb_device.cc:22: 0xff,
optional: consider adding comments with the field names next to the test values
to make it easier for readers, e.g.

UsbDevice(0x0200,  /* usb_version */
          0xff,    /* device_class */ 
... etc.


(down below too)

[Reilly Grant (use Gerrit), 2016-04-05 01:32:26]

Description was changed from

==========
Include USB device version in chrome.usb.Device fields.

This field is sometimes necessary to determine the protocol supported by
a device as it may change from one version of a device with the same
vendor and product ID pair to the next.

While plumbing this through //device/usb this patch also adds a number
of other device descriptor fields that are exposed through the Mojo
interface but weren't actually hooked up.

BUG=598825
==========

to

==========
Include USB device version in chrome.usb.Device fields.

This field is sometimes necessary to determine the protocol supported by
a device as it may change from one version of a device with the same
vendor and product ID pair to the next.

While plumbing this through //device/usb this patch also adds a number
of other device descriptor fields that are exposed through the Mojo
interface but weren't actually hooked up.

BUG=598825
TBR=yurys@chromium.org
==========

[Reilly Grant (use Gerrit), 2016-04-05 01:32:32]

The CQ bit was checked by reillyg@chromium.org

[Reilly Grant (use Gerrit), 2016-04-05 01:32:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
asargent@chromium.org
Link to the patchset: https://codereview.chromium.org/1857033002/#ps40001
(title: "Commented parameters.")

[commit-bot: I haz the power, 2016-04-05 01:33:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1857033002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1857033002/40001

[commit-bot: I haz the power, 2016-04-05 02:02:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-05 02:02:32]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[Reilly Grant (use Gerrit), 2016-04-05 20:38:42]

Please take another look as I just had to add a bit of code for Android support.

[asargent_no_longer_on_chrome, 2016-04-05 21:31:17]

new version lgtm

https://codereview.chromium.org/1857033002/diff/60001/device/usb/usb_device_a...
File device/usb/usb_device_android.cc (right):

https://codereview.chromium.org/1857033002/diff/60001/device/usb/usb_device_a...
device/usb/usb_device_android.cc:49: 0x0000,  // Device version, not available
until API version 23.
Out of curiousity, is it possible to have a method in ChromeUsbDevice.java which
checks the API version at runtime and either returns 0x0000 or the actual value,
as appropriate?

[Reilly Grant (use Gerrit), 2016-04-05 23:30:20]

On 2016/04/05 at 21:31:17, asargent wrote:
> new version lgtm
> 
>
https://codereview.chromium.org/1857033002/diff/60001/device/usb/usb_device_a...
> File device/usb/usb_device_android.cc (right):
> 
>
https://codereview.chromium.org/1857033002/diff/60001/device/usb/usb_device_a...
> device/usb/usb_device_android.cc:49: 0x0000,  // Device version, not available
until API version 23.
> Out of curiousity, is it possible to have a method in ChromeUsbDevice.java
which checks the API version at runtime and either returns 0x0000 or the actual
value, as appropriate?

Added a getter.

[asargent_no_longer_on_chrome, 2016-04-06 16:56:59]

nice, new version lgtm

[Reilly Grant (use Gerrit), 2016-04-06 21:47:15]

The CQ bit was checked by reillyg@chromium.org

[Reilly Grant (use Gerrit), 2016-04-06 21:47:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
asargent@chromium.org
Link to the patchset: https://codereview.chromium.org/1857033002/#ps100001
(title: "Rebased.")

[commit-bot: I haz the power, 2016-04-06 21:48:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1857033002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1857033002/100001

[commit-bot: I haz the power, 2016-04-07 02:20:42]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2016-04-07 02:22:19]

Description was changed from

==========
Include USB device version in chrome.usb.Device fields.

This field is sometimes necessary to determine the protocol supported by
a device as it may change from one version of a device with the same
vendor and product ID pair to the next.

While plumbing this through //device/usb this patch also adds a number
of other device descriptor fields that are exposed through the Mojo
interface but weren't actually hooked up.

BUG=598825
TBR=yurys@chromium.org
==========

to

==========
Include USB device version in chrome.usb.Device fields.

This field is sometimes necessary to determine the protocol supported by
a device as it may change from one version of a device with the same
vendor and product ID pair to the next.

While plumbing this through //device/usb this patch also adds a number
of other device descriptor fields that are exposed through the Mojo
interface but weren't actually hooked up.

BUG=598825
TBR=yurys@chromium.org

Committed: https://crrev.com/a8a7407bab1e16cf519cb84eb73eb3c030f87528
Cr-Commit-Position: refs/heads/master@{#385617}
==========

[commit-bot: I haz the power, 2016-04-07 02:22:20]

Patchset 5 (id:??) landed as
https://crrev.com/a8a7407bab1e16cf519cb84eb73eb3c030f87528
Cr-Commit-Position: refs/heads/master@{#385617}

[xpersany, 2017-07-15 22:07:00]

xpersany@gmail.com changed reviewers:
+ xpersany@gmail.com