Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1746)

Unified Diff: device/usb/usb_device_android.cc

Issue 1857033002: Include USB device version in chrome.usb.Device fields. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « device/usb/usb_device_android.h ('k') | device/usb/usb_device_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/usb/usb_device_android.cc
diff --git a/device/usb/usb_device_android.cc b/device/usb/usb_device_android.cc
index b1a2baacdd99f9c02ae94f883b40ece4a97f5b94..53873a994c87cb37e2b132d0393b0b1cf3cede8a 100644
--- a/device/usb/usb_device_android.cc
+++ b/device/usb/usb_device_android.cc
@@ -32,8 +32,9 @@ scoped_refptr<UsbDeviceAndroid> UsbDeviceAndroid::Create(
const JavaRef<jobject>& usb_device) {
ScopedJavaLocalRef<jobject> wrapper =
Java_ChromeUsbDevice_create(env, usb_device.obj());
- uint16_t vendor_id = Java_ChromeUsbDevice_getVendorId(env, wrapper.obj());
- uint16_t product_id = Java_ChromeUsbDevice_getProductId(env, wrapper.obj());
+ uint16_t device_version = 0;
+ if (base::android::BuildInfo::GetInstance()->sdk_int() >= 23)
+ device_version = Java_ChromeUsbDevice_getDeviceVersion(env, wrapper.obj());
ScopedJavaLocalRef<jstring> manufacturer_string =
Java_ChromeUsbDevice_getManufacturerName(env, wrapper.obj());
ScopedJavaLocalRef<jstring> product_string =
@@ -41,7 +42,13 @@ scoped_refptr<UsbDeviceAndroid> UsbDeviceAndroid::Create(
ScopedJavaLocalRef<jstring> serial_number =
Java_ChromeUsbDevice_getSerialNumber(env, wrapper.obj());
return make_scoped_refptr(new UsbDeviceAndroid(
- env, vendor_id, product_id,
+ env,
+ 0x0200, // USB protocol version, not provided by the Android API.
+ Java_ChromeUsbDevice_getDeviceClass(env, wrapper.obj()),
+ Java_ChromeUsbDevice_getDeviceSubclass(env, wrapper.obj()),
+ Java_ChromeUsbDevice_getDeviceProtocol(env, wrapper.obj()),
+ Java_ChromeUsbDevice_getVendorId(env, wrapper.obj()),
+ Java_ChromeUsbDevice_getProductId(env, wrapper.obj()), device_version,
ConvertJavaStringToUTF16(env, manufacturer_string),
ConvertJavaStringToUTF16(env, product_string),
ConvertJavaStringToUTF16(env, serial_number), wrapper));
@@ -57,14 +64,24 @@ const UsbConfigDescriptor* UsbDeviceAndroid::GetActiveConfiguration() const {
}
UsbDeviceAndroid::UsbDeviceAndroid(JNIEnv* env,
+ uint16_t usb_version,
+ uint8_t device_class,
+ uint8_t device_subclass,
+ uint8_t device_protocol,
uint16_t vendor_id,
uint16_t product_id,
+ uint16_t device_version,
const base::string16& manufacturer_string,
const base::string16& product_string,
const base::string16& serial_number,
const JavaRef<jobject>& wrapper)
- : UsbDevice(vendor_id,
+ : UsbDevice(usb_version,
+ device_class,
+ device_subclass,
+ device_protocol,
+ vendor_id,
product_id,
+ device_version,
manufacturer_string,
product_string,
serial_number) {
« no previous file with comments | « device/usb/usb_device_android.h ('k') | device/usb/usb_device_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698