device/usb/mock_usb_device.cc - Issue 1857033002: Include USB device version in chrome.usb.Device fields.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/usb/mock_usb_device.cc

Issue 1857033002: Include USB device version in chrome.usb.Device fields. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « device/usb/android/java/src/org/chromium/device/usb/ChromeUsbDevice.java ('k') | device/usb/mojo/type_converters.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: device/usb/mock_usb_device.cc

diff --git a/device/usb/mock_usb_device.cc b/device/usb/mock_usb_device.cc

index 49b2252ac346b96c25497ab1e9110d7f5f738bc3..0f6c49ca6019e7e6c75c780ef7bb58c71672eb63 100644

--- a/device/usb/mock_usb_device.cc

+++ b/device/usb/mock_usb_device.cc

@@ -16,8 +16,13 @@ MockUsbDevice::MockUsbDevice(uint16_t vendor_id,

const std::string& manufacturer_string,

const std::string& product_string,

const std::string& serial_number)

- : UsbDevice(vendor_id,

+ : UsbDevice(0x0200, // usb_version

+ 0xff, // device_class

+ 0xff, // device_subclass

+ 0xff, // device_protocol

+ vendor_id,

product_id,

+ 0x0100, // device_version

base::UTF8ToUTF16(manufacturer_string),

base::UTF8ToUTF16(product_string),

base::UTF8ToUTF16(serial_number)) {}

@@ -28,8 +33,13 @@ MockUsbDevice::MockUsbDevice(uint16_t vendor_id,