unbundle: add replace_gn_files.py and unbundled GN file for libxml

unbundle: add replace_gn_files.py and unbundled GN file for libxml

BUG=551343
R=dpranke@chromium.org, thestig@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/9fc3d746041ab3371f17b5b57e3b7dfc3b6888d7

[Paweł Hajdan Jr., 2016-04-04 16:14:54]

phajdan.jr@chromium.org changed reviewers:
+ dpranke@chromium.org, thestig@chromium.org

[Dirk Pranke, 2016-04-04 20:58:35]

I have no idea what this is doing or why we need this, except that I think this
has something to do w/ supporting distros and using system versions of
something.

Is there some larger context or design doc you can point me at?

[Paweł Hajdan Jr., 2016-04-04 21:21:59]

See e.g.
https://code.google.com/p/chromium/codesearch#chromium/src/build/linux/unbund...

Also possibly these two:

http://events.linuxfoundation.org/sites/events/files/slides/LinuxCon%202014%2...

https://lwn.net/Articles/619158/

Given that build/linux/unbundle is *never* used by Chrome build *ever* , I'd
hope for pretty much a rubber stamp unless you see something really horrifying
here. FWIW, replace_gn_files.py is based on replace_gyp_files.py .

[Lei Zhang, 2016-04-04 21:46:28]

Update build/linux/unbundle/README with instructions for replace_gn_files.py?

https://codereview.chromium.org/1856753003/diff/20001/build/linux/unbundle/li...
File build/linux/unbundle/libxml.gn (right):

https://codereview.chromium.org/1856753003/diff/20001/build/linux/unbundle/li...
build/linux/unbundle/libxml.gn:1: # Copyright 2016 The Chromium Authors. All
rights reserved.
You should cross-reference with build/linux/unbundle/libxml.gyp and vice versa,
like any other GYP <-> GN file.

https://codereview.chromium.org/1856753003/diff/20001/build/linux/unbundle/re...
File build/linux/unbundle/replace_gn_files.py (right):

https://codereview.chromium.org/1856753003/diff/20001/build/linux/unbundle/re...
build/linux/unbundle/replace_gn_files.py:51: # Copy the gyp file from directory
of this script to target path.
s/gyp/gn/ ?

[Paweł Hajdan Jr., 2016-04-05 13:22:56]

PTAL

https://codereview.chromium.org/1856753003/diff/20001/build/linux/unbundle/li...
File build/linux/unbundle/libxml.gn (right):

https://codereview.chromium.org/1856753003/diff/20001/build/linux/unbundle/li...
build/linux/unbundle/libxml.gn:1: # Copyright 2016 The Chromium Authors. All
rights reserved.
On 2016/04/04 at 21:46:28, Lei Zhang wrote:
> You should cross-reference with build/linux/unbundle/libxml.gyp and vice
versa, like any other GYP <-> GN file.

Is there a standard way to do this? I haven't seen a style guide entry about
this, and the codebase doesn't seem to be consistent about it.

FWIW, real libxml GN/GYP files don't seem to have such cross-references.

Furthermore, since build/linux/unbundle is *NOT* really part of "mainline"
chromium codebase, it's also not in scope for GYP->GN migration.

I don't see any real use for adding cross-references here, especially if the
request is so vague. I could put something if you give a very specific
suggestion how such patch/comment should look like.

https://codereview.chromium.org/1856753003/diff/20001/build/linux/unbundle/re...
File build/linux/unbundle/replace_gn_files.py (right):

https://codereview.chromium.org/1856753003/diff/20001/build/linux/unbundle/re...
build/linux/unbundle/replace_gn_files.py:51: # Copy the gyp file from directory
of this script to target path.
On 2016/04/04 at 21:46:28, Lei Zhang wrote:
> s/gyp/gn/ ?

Done.

[Dirk Pranke, 2016-04-05 17:17:55]

lgtm.

Thanks for the links, they gave me the context I was looking for.

(I don't tend to like to rubber stamp things I know nothing about :).

[Lei Zhang, 2016-04-05 18:35:33]

lgtm

[commit-bot: I haz the power, 2016-04-06 09:18:04]

Description was changed from

==========
unbundle: add replace_gn_files.py and unbundled GN file for libxml

BUG=551343
==========

to

==========
unbundle: add replace_gn_files.py and unbundled GN file for libxml

BUG=551343
R=dpranke@chromium.org, thestig@chromium.org

Committed: https://crrev.com/9fc3d746041ab3371f17b5b57e3b7dfc3b6888d7
Cr-Commit-Position: refs/heads/master@{#385414}
==========

[commit-bot: I haz the power, 2016-04-06 09:18:05]

Patchset 3 (id:??) landed as
https://crrev.com/9fc3d746041ab3371f17b5b57e3b7dfc3b6888d7
Cr-Commit-Position: refs/heads/master@{#385414}

[Paweł Hajdan Jr., 2016-04-06 09:18:47]

Description was changed from

==========
unbundle: add replace_gn_files.py and unbundled GN file for libxml

BUG=551343
R=dpranke@chromium.org, thestig@chromium.org

Committed: https://crrev.com/9fc3d746041ab3371f17b5b57e3b7dfc3b6888d7
Cr-Commit-Position: refs/heads/master@{#385414}
==========

to

==========
unbundle: add replace_gn_files.py and unbundled GN file for libxml

BUG=551343
R=dpranke@chromium.org, thestig@chromium.org

Committed:
https://chromium.googlesource.com/chromium/src/+/9fc3d746041ab3371f17b5b57e3b...
==========

[Paweł Hajdan Jr., 2016-04-06 09:18:49]

Committed patchset #3 (id:40001) manually as
9fc3d746041ab3371f17b5b57e3b7dfc3b6888d7 (presubmit successful).