build/linux/unbundle/libxml.gn - Issue 1856753003: unbundle: add replace_gn_files.py and unbundled GN file for libxml

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: build/linux/unbundle/libxml.gn

Issue 1856753003: unbundle: add replace_gn_files.py and unbundled GN file for libxml (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: simplify Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 # Copyright 2016 The Chromium Authors. All rights reserved.
	Lei Zhang 2016/04/04 21:46:28 You should cross-reference with build/linux/unbund You should cross-reference with build/linux/unbundle/libxml.gyp and vice versa, like any other GYP <-> GN file. Paweł Hajdan Jr. 2016/04/05 13:22:56 Is there a standard way to do this? I haven't seen Show quoted text On 2016/04/04 at 21:46:28, Lei Zhang wrote: > You should cross-reference with build/linux/unbundle/libxml.gyp and vice versa, like any other GYP <-> GN file. Is there a standard way to do this? I haven't seen a style guide entry about this, and the codebase doesn't seem to be consistent about it. FWIW, real libxml GN/GYP files don't seem to have such cross-references. Furthermore, since build/linux/unbundle is NOT really part of "mainline" chromium codebase, it's also not in scope for GYP->GN migration. I don't see any real use for adding cross-references here, especially if the request is so vague. I could put something if you give a very specific suggestion how such patch/comment should look like.
	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 import("//build/config/linux/pkg_config.gni")

	6

	7 pkg_config("system_libxml") {

	8 packages = [ "libxml-2.0" ]

	9 }

	10

	11 static_library("libxml") {

	12 sources = [

	13 "chromium/libxml_utils.cc",

	14 "chromium/libxml_utils.h",

	15 ]

	16

	17 public_configs = [ ":system_libxml" ]

	18 }

OLD	NEW

« no previous file with comments | « no previous file | build/linux/unbundle/replace_gn_files.py » ('j') | build/linux/unbundle/replace_gn_files.py » ('J')