Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: build/linux/unbundle/README

Issue 1856753003: unbundle: add replace_gn_files.py and unbundled GN file for libxml (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixes Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/linux/unbundle/libxml.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/linux/unbundle/README
diff --git a/build/linux/unbundle/README b/build/linux/unbundle/README
index d1b2a966eff7deb8bea8bfbe0f87e111d111a6cf..8c77b75b66efbe522646c8b870e1907f4fec580a 100644
--- a/build/linux/unbundle/README
+++ b/build/linux/unbundle/README
@@ -9,9 +9,14 @@ For more info please read the following:
For more Chromium-specific context please read
http://spot.livejournal.com/312320.html .
+Additional resources which might provide even more context:
+
+ - http://events.linuxfoundation.org/sites/events/files/slides/LinuxCon%202014%20Slides_0.pdf
+ - https://lwn.net/Articles/619158/
+
This directory is provided in the source tree to follow above guidelines.
It is a compromise solution which takes into account Chromium developers
-who want to avoid the perceived burden of more conditional code in gyp,
+who want to avoid the perceived burden of more conditional code in build files,
and expectations of Open Source community, where using system-provided
libraries is the norm.
@@ -32,13 +37,19 @@ Usage:
NOTE: by default this will not remove anything (for safety). Pass
--do-remove flag to actually remove files.
-2. replace_gyp_files.py <gyp-flags>
+2. Pick the script to run depending on whether you use GYP or GN:
+
+2a. replace_gyp_files.py <gyp-flags>
+
+ For example: replace_gyp_files.py -Duse_system_harfbuzz=1
+
+ The script ignores flags other than -D for convenience. This makes it
+ possible to have a variable e.g. ${myconf} with all the options, and
+ execute:
- For example: replace_gyp_files.py -Duse_system_harfbuzz=1
+ build/linux/unbundle/replace_gyp_files.py ${myconf}
+ build/gyp_chromium ${myconf}
- The script ignores flags other than -D for convenience. This makes it
- possible to have a variable e.g. ${myconf} with all the options, and
- execute:
+2b. replace_gn_files.py --system-libraries lib...
- build/linux/unbundle/replace_gyp_files.py ${myconf}
- build/gyp_chromium ${myconf}
+ For example: replace_gn_files.py --system-libraries libxml
« no previous file with comments | « no previous file | build/linux/unbundle/libxml.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698