Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 1856703002: Revert of Rename enums in GrContextFactory to remove "GL" (Closed)

Created:
4 years, 8 months ago by bsalomon
Modified:
4 years, 8 months ago
Reviewers:
jvanverth1, egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Rename enums in GrContextFactory to remove "GL" (patchset #4 id:60001 of https://codereview.chromium.org/1845923004/ ) Reason for revert: Many GM images unexpectedly changed with this CL. Original issue's description: > Rename enums in GrContextFactory to remove "GL" > > Also, remove kNative as a separate context type and instead make it an alias for kGL or kGLES based on OS. > > > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1845923004 > > Committed: https://skia.googlesource.com/skia/+/2d9c6f81353597aebf5934547e5cba7a872196fb TBR=egdaniel@google.com,jvanverth@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. Committed: https://skia.googlesource.com/skia/+/b4b4cf36c66900fdfaf63106d54a8fac786a3313

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+184 lines, -181 lines) Patch
M bench/nanobench.h View 1 chunk +2 lines, -2 lines 0 comments Download
M bench/nanobench.cpp View 4 chunks +8 lines, -8 lines 0 comments Download
M dm/DM.cpp View 3 chunks +22 lines, -23 lines 0 comments Download
M dm/DMGpuSupport.h View 3 chunks +17 lines, -19 lines 0 comments Download
M dm/DMSrcSink.h View 2 chunks +4 lines, -4 lines 0 comments Download
M dm/DMSrcSink.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/GrContextAbandonTest.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/GrContextFactoryTest.cpp View 5 chunks +17 lines, -15 lines 0 comments Download
M tests/GrPorterDuffTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/ImageTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/SkpSkGrTest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/TestConfigParsing.cpp View 3 chunks +14 lines, -10 lines 0 comments Download
M tests/VkClearTests.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/VkUploadPixelsTests.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/VkWrapTests.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M tools/flags/SkCommonFlagsConfig.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/flags/SkCommonFlagsConfig.cpp View 2 chunks +13 lines, -9 lines 0 comments Download
M tools/gpu/GrContextFactory.h View 2 chunks +37 lines, -36 lines 0 comments Download
M tools/gpu/GrContextFactory.cpp View 5 chunks +17 lines, -22 lines 0 comments Download
M tools/kilobench/kilobench.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M tools/skiaserve/Request.cpp View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
bsalomon
Created Revert of Rename enums in GrContextFactory to remove "GL"
4 years, 8 months ago (2016-04-04 12:37:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1856703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1856703002/1
4 years, 8 months ago (2016-04-04 12:37:45 UTC) #2
commit-bot: I haz the power
4 years, 8 months ago (2016-04-04 12:57:03 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/b4b4cf36c66900fdfaf63106d54a8fac786a3313

Powered by Google App Engine
This is Rietveld 408576698