Adding the RemoteSecurityKeyMessageHandler class.

Adding the RemoteSecurityKeyMessageHandler class.

This new class connects a RemoteSecurityKeyIpcClient instance with a
RemoteSecurityKeyMessageReader and RemoteSecurityKeyMessageWriter instances
to allow security key messages to pass between the local security key enabled
tools and the remote client.  In between is a chunk of logic which handles
specific security key messages from the local tools as well as the remote
security key responses from the IPC Client.

BUG=584463
Committed: https://crrev.com/880f42515d1bac89d2bb05c5789b53e6c00c57af
Cr-Commit-Position: refs/heads/master@{#385298}

[joedow, 2016-04-04 18:51:12]

joedow@chromium.org changed reviewers:
+ sergeyu@chromium.org

[joedow, 2016-04-04 18:51:13]

PTAL!

Thanks,
Joe

[joedow, 2016-04-05 02:26:17]

The CQ bit was checked by joedow@chromium.org to run a CQ dry run

[joedow, 2016-04-05 02:26:20]

The CQ bit was unchecked by joedow@chromium.org

[joedow, 2016-04-05 16:22:51]

Ping!

[Sergey Ulanov, 2016-04-05 18:57:40]

lgtm

https://codereview.chromium.org/1855613002/diff/80001/remoting/host/security_...
File remoting/host/security_key/remote_security_key_message_handler.cc (right):

https://codereview.chromium.org/1855613002/diff/80001/remoting/host/security_...
remoting/host/security_key/remote_security_key_message_handler.cc:21: base::File
DuplicatePlatformFile(base::File file) {
Do you really need this function? There is base::File::Duplicate() which does
exactly the same thing, except without the DUPLICATE_CLOSE_SOURCE flag. I think
you can just close the source file explicitly.

https://codereview.chromium.org/1855613002/diff/80001/remoting/host/security_...
remoting/host/security_key/remote_security_key_message_handler.cc:193: void
RemoteSecurityKeyMessageHandler::Shutdown() {
Maybe call this OnError() to make it clear it's used to handle errors?

[joedow, 2016-04-05 21:29:30]

Thanks!

https://codereview.chromium.org/1855613002/diff/80001/remoting/host/security_...
File remoting/host/security_key/remote_security_key_message_handler.cc (right):

https://codereview.chromium.org/1855613002/diff/80001/remoting/host/security_...
remoting/host/security_key/remote_security_key_message_handler.cc:21: base::File
DuplicatePlatformFile(base::File file) {
On 2016/04/05 18:57:40, Sergey Ulanov wrote:
> Do you really need this function? There is base::File::Duplicate() which does
> exactly the same thing, except without the DUPLICATE_CLOSE_SOURCE flag. I
think
> you can just close the source file explicitly.

Done.

https://codereview.chromium.org/1855613002/diff/80001/remoting/host/security_...
remoting/host/security_key/remote_security_key_message_handler.cc:193: void
RemoteSecurityKeyMessageHandler::Shutdown() {
On 2016/04/05 18:57:40, Sergey Ulanov wrote:
> Maybe call this OnError() to make it clear it's used to handle errors?

Done.

[joedow, 2016-04-05 21:35:20]

The CQ bit was checked by joedow@chromium.org

[joedow, 2016-04-05 21:35:21]

The patchset sent to the CQ was uploaded after l-g-t-m from sergeyu@chromium.org
Link to the patchset: https://codereview.chromium.org/1855613002/#ps100001
(title: "Addressing feedback")

[commit-bot: I haz the power, 2016-04-05 21:35:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1855613002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1855613002/100001

[commit-bot: I haz the power, 2016-04-05 22:10:02]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-04-05 22:11:07]

Description was changed from

==========
Adding the RemoteSecurityKeyMessageHandler class.

This new class connects a RemoteSecurityKeyIpcClient instance with a
RemoteSecurityKeyMessageReader and RemoteSecurityKeyMessageWriter instances
to allow security key messages to pass between the local security key enabled
tools and the remote client.  In between is a chunk of logic which handles
specific security key messages from the local tools as well as the remote
security key responses from the IPC Client.

BUG=584463
==========

to

==========
Adding the RemoteSecurityKeyMessageHandler class.

This new class connects a RemoteSecurityKeyIpcClient instance with a
RemoteSecurityKeyMessageReader and RemoteSecurityKeyMessageWriter instances
to allow security key messages to pass between the local security key enabled
tools and the remote client.  In between is a chunk of logic which handles
specific security key messages from the local tools as well as the remote
security key responses from the IPC Client.

BUG=584463

Committed: https://crrev.com/880f42515d1bac89d2bb05c5789b53e6c00c57af
Cr-Commit-Position: refs/heads/master@{#385298}
==========

[commit-bot: I haz the power, 2016-04-05 22:11:08]

Patchset 6 (id:??) landed as
https://crrev.com/880f42515d1bac89d2bb05c5789b53e6c00c57af
Cr-Commit-Position: refs/heads/master@{#385298}