Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 1826613003: Updating the remote_security_key to use the new message processing classes. (Closed)

Created:
4 years, 9 months ago by joedow
Modified:
4 years, 8 months ago
Reviewers:
Sergey Ulanov, dcheng
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@handler
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Updating the remote_security_key to use the new message processing classes. This change updates the main function used in the remote_security_key process so it creates the appropriate classes to handle IPC and STDIO messages and then starts the handlers to process those messages until it is told to quit. BUG=584463 Committed: https://crrev.com/e7680c79e7ebc47ffed579fe29c1bf574089999d Cr-Commit-Position: refs/heads/master@{#385543}

Patch Set 1 #

Patch Set 2 : Updating the CL after the removal of the Message Channel class. #

Patch Set 3 : Merging in latest handler changes. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -0 lines) Patch
M remoting/host/security_key/remote_security_key_main.cc View 1 2 1 chunk +45 lines, -0 lines 1 comment Download

Depends on Patchset:

Messages

Total messages: 13 (4 generated)
joedow
PTAL! Thanks, Joe
4 years, 8 months ago (2016-04-05 21:39:40 UTC) #2
joedow
Ping!
4 years, 8 months ago (2016-04-06 16:24:20 UTC) #3
Sergey Ulanov
lgtm
4 years, 8 months ago (2016-04-06 20:07:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1826613003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1826613003/40001
4 years, 8 months ago (2016-04-06 20:12:52 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-06 20:22:24 UTC) #7
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/e7680c79e7ebc47ffed579fe29c1bf574089999d Cr-Commit-Position: refs/heads/master@{#385543}
4 years, 8 months ago (2016-04-06 20:24:04 UTC) #9
dcheng
https://codereview.chromium.org/1826613003/diff/40001/remoting/host/security_key/remote_security_key_main.cc File remoting/host/security_key/remote_security_key_main.cc (right): https://codereview.chromium.org/1826613003/diff/40001/remoting/host/security_key/remote_security_key_main.cc#newcode50 remoting/host/security_key/remote_security_key_main.cc:50: scoped_ptr<RemoteSecurityKeyIpcClient> ipc_client( Please don't forget to IWYU, this collided ...
4 years, 8 months ago (2016-04-06 23:12:22 UTC) #11
joedow
On 2016/04/06 23:12:22, dcheng wrote: > https://codereview.chromium.org/1826613003/diff/40001/remoting/host/security_key/remote_security_key_main.cc > File remoting/host/security_key/remote_security_key_main.cc (right): > > https://codereview.chromium.org/1826613003/diff/40001/remoting/host/security_key/remote_security_key_main.cc#newcode50 > ...
4 years, 8 months ago (2016-04-06 23:16:42 UTC) #12
dcheng
4 years, 8 months ago (2016-04-06 23:18:07 UTC) #13
Message was sent while issue was closed.
On 2016/04/06 at 23:16:42, joedow wrote:
> On 2016/04/06 23:12:22, dcheng wrote:
> >
https://codereview.chromium.org/1826613003/diff/40001/remoting/host/security_...
> > File remoting/host/security_key/remote_security_key_main.cc (right):
> > 
> >
https://codereview.chromium.org/1826613003/diff/40001/remoting/host/security_...
> > remoting/host/security_key/remote_security_key_main.cc:50:
> > scoped_ptr<RemoteSecurityKeyIpcClient> ipc_client(
> > Please don't forget to IWYU, this collided with
> > https://codereview.chromium.org/1864213002 and broke the build.
> 
> I seems like this patch landed ~2 hours before the referenced CL.  I'm happy
to update it with the changes from your CL.

Sure, the problem is the CQ run for the later patch didn't include this
particular revision, hence collision.

Powered by Google App Engine
This is Rietveld 408576698