Adding the RemoteSecurityKeyMessageHandler class.

remoting/host/security_key/remote_security_key_message_handler.cc

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "remoting/host/security_key/remote_security_key_message_handler.h"
+
+#include <cstdint>
+#include <string>
+#include <utility>
+
+#include "base/bind.h"
+#include "base/callback.h"
+#include "base/callback_helpers.h"
+#include "remoting/host/security_key/remote_security_key_ipc_client.h"
+#include "remoting/host/security_key/remote_security_key_ipc_constants.h"
+#include "remoting/host/security_key/remote_security_key_message_reader_impl.h"
+#include "remoting/host/security_key/remote_security_key_message_writer_impl.h"
+
+namespace {
+
+base::File DuplicatePlatformFile(base::File file) {

[Sergey Ulanov, 2016/04/05 18:57:40]

Do you really need this function? There is base::File::Duplicate() which does
exactly the same thing, except without the DUPLICATE_CLOSE_SOURCE flag. I think
you can just close the source file explicitly.

[joedow, 2016/04/05 21:29:30]

Done.

+  base::PlatformFile result;
+#if defined(OS_WIN)
+  if (!DuplicateHandle(GetCurrentProcess(), file.TakePlatformFile(),
+                       GetCurrentProcess(), &result, 0, FALSE,
+                       DUPLICATE_CLOSE_SOURCE | DUPLICATE_SAME_ACCESS)) {
+    PLOG(ERROR) << "Failed to duplicate handle " << file.GetPlatformFile();
+    return base::File();
+  }
+  return base::File(result);
+#elif defined(OS_POSIX)
+  result = dup(file.GetPlatformFile());
+  return base::File(result);
+#else
+#error Not implemented.
+#endif
+}
+
+}  // namespace
+
+namespace remoting {
+
+RemoteSecurityKeyMessageHandler::RemoteSecurityKeyMessageHandler() {}
+
+RemoteSecurityKeyMessageHandler::~RemoteSecurityKeyMessageHandler() {}
+
+void RemoteSecurityKeyMessageHandler::Start(
+    base::File message_read_stream,
+    base::File message_write_stream,
+    scoped_ptr<RemoteSecurityKeyIpcClient> ipc_client,
+    const base::Closure& shutdown_closure) {
+  DCHECK(thread_checker_.CalledOnValidThread());
+  DCHECK(message_read_stream.IsValid());
+  DCHECK(message_write_stream.IsValid());
+  DCHECK(ipc_client);
+  DCHECK(!shutdown_closure.is_null());
+  DCHECK(shutdown_closure_.is_null());
+
+  if (!reader_) {
+    reader_.reset(new RemoteSecurityKeyMessageReaderImpl(
+        DuplicatePlatformFile(std::move(message_read_stream))));
+  }
+
+  if (!writer_) {
+    writer_.reset(new RemoteSecurityKeyMessageWriterImpl(
+        DuplicatePlatformFile(std::move(message_write_stream))));
+  }
+
+  ipc_client_ = std::move(ipc_client);
+  shutdown_closure_ = shutdown_closure;
+
+  reader_->Start(
+      base::Bind(
+          &RemoteSecurityKeyMessageHandler::ProcessRemoteSecurityKeyMessage,
+          base::Unretained(this)),
+      base::Bind(&RemoteSecurityKeyMessageHandler::Shutdown,
+                 base::Unretained(this)));
+}
+
+void RemoteSecurityKeyMessageHandler::SetRemoteSecurityKeyMessageReaderForTest(
+    scoped_ptr<RemoteSecurityKeyMessageReader> reader) {
+  DCHECK(!reader_);
+  reader_ = std::move(reader);
+}
+
+void RemoteSecurityKeyMessageHandler::SetRemoteSecurityKeyMessageWriterForTest(
+    scoped_ptr<RemoteSecurityKeyMessageWriter> writer) {
+  DCHECK(!writer_);
+  writer_ = std::move(writer);
+}
+
+void RemoteSecurityKeyMessageHandler::ProcessRemoteSecurityKeyMessage(
+    scoped_ptr<SecurityKeyMessage> message) {
+  DCHECK(thread_checker_.CalledOnValidThread());
+
+  RemoteSecurityKeyMessageType message_type = message->type();
+  if (message_type == RemoteSecurityKeyMessageType::CONNECT) {
+    HandleConnectRequest(message->payload());
+  } else if (message_type == RemoteSecurityKeyMessageType::REQUEST) {
+    HandleSecurityKeyRequest(message->payload());
+  } else {
+    LOG(ERROR) << "Unknown message type: "
+               << static_cast<uint8_t>(message_type);
+    SendMessage(RemoteSecurityKeyMessageType::UNKNOWN_COMMAND);
+  }
+}
+
+void RemoteSecurityKeyMessageHandler::HandleIpcConnectionChange(
+    bool connection_established) {
+  DCHECK(thread_checker_.CalledOnValidThread());
+  if (connection_established) {
+    SendMessageWithPayload(RemoteSecurityKeyMessageType::CONNECT_RESPONSE, "1");
+  } else {
+    SendMessageWithPayload(
+        RemoteSecurityKeyMessageType::CONNECT_ERROR,
+        "Unknown error occurred while establishing connection.");
+  }
+}
+
+void RemoteSecurityKeyMessageHandler::HandleSecurityKeyResponse(
+    const std::string& response_data) {
+  if (response_data.compare(kRemoteSecurityKeyConnectionError) == 0) {
+    SendMessageWithPayload(RemoteSecurityKeyMessageType::REQUEST_ERROR,
+                           "An error occurred during the request.");
+    return;
+  }
+
+  if (response_data.empty()) {
+    SendMessageWithPayload(RemoteSecurityKeyMessageType::REQUEST_ERROR,
+                           "Invalid client response received.");
+    return;
+  }
+
+  SendMessageWithPayload(RemoteSecurityKeyMessageType::REQUEST_RESPONSE,
+                         response_data);
+}
+
+void RemoteSecurityKeyMessageHandler::HandleConnectRequest(
+    const std::string& message_payload) {
+  DCHECK(thread_checker_.CalledOnValidThread());
+  if (!message_payload.empty()) {
+    SendMessageWithPayload(RemoteSecurityKeyMessageType::CONNECT_ERROR,
+                           "Unexpected payload data received.");
+    return;
+  }
+
+  if (ipc_client_->WaitForSecurityKeyIpcServerChannel()) {
+    // If we find an IPC server, then attempt to establish a connection.
+    ipc_client_->EstablishIpcConnection(
+        base::Bind(&RemoteSecurityKeyMessageHandler::HandleIpcConnectionChange,
+                   base::Unretained(this), true),
+        base::Bind(&RemoteSecurityKeyMessageHandler::HandleIpcConnectionChange,
+                   base::Unretained(this), false));
+  } else {
+    SendMessageWithPayload(RemoteSecurityKeyMessageType::CONNECT_RESPONSE, "0");
+  }
+}
+
+void RemoteSecurityKeyMessageHandler::HandleSecurityKeyRequest(
+    const std::string& message_payload) {
+  DCHECK(thread_checker_.CalledOnValidThread());
+  if (message_payload.empty()) {
+    SendMessageWithPayload(RemoteSecurityKeyMessageType::REQUEST_ERROR,
+                           "Request sent without request data.");
+    return;
+  }
+
+  if (!ipc_client_->SendSecurityKeyRequest(
+          message_payload,
+          base::Bind(
+              &RemoteSecurityKeyMessageHandler::HandleSecurityKeyResponse,
+              base::Unretained(this)))) {
+    SendMessageWithPayload(RemoteSecurityKeyMessageType::REQUEST_ERROR,
+                           "Failed to send request data.");
+  }
+}
+
+void RemoteSecurityKeyMessageHandler::SendMessage(
+    RemoteSecurityKeyMessageType message_type) {
+  if (!writer_->WriteMessage(message_type)) {
+    Shutdown();
+  }
+}
+
+void RemoteSecurityKeyMessageHandler::SendMessageWithPayload(
+    RemoteSecurityKeyMessageType message_type,
+    const std::string& message_payload) {
+  if (!writer_->WriteMessageWithPayload(message_type, message_payload)) {
+    Shutdown();
+  }
+}
+
+void RemoteSecurityKeyMessageHandler::Shutdown() {

[Sergey Ulanov, 2016/04/05 18:57:40]

Maybe call this OnError() to make it clear it's used to handle errors?

[joedow, 2016/04/05 21:29:30]

Done.

+  DCHECK(thread_checker_.CalledOnValidThread());
+  ipc_client_.reset();
+  writer_.reset();
+  reader_.reset();
+
+  if (!shutdown_closure_.is_null()) {
+    base::ResetAndReturn(&shutdown_closure_).Run();
+  }
+}
+
+}  // namespace remoting