Issue 26096. Explicitly compute the result that ensures that directives are resolved in units.

Issue 26096. Explicitly compute the result that ensures that directives are resolved in units.

In the past computing LIBRARY_ELEMENT2 also set elements for directives
in the defining unit AST. But when this unit is flushed and reparsed
we didn't set these directive elements again because LIBRARY_ELEMENT2
is valid. Now resolving directive ASTs to elements is an explicit
dependency.

R=brianwilkerson@google.com, paulberry@google.com
BUG= https://github.com/dart-lang/sdk/issues/26096

Committed: https://github.com/dart-lang/sdk/commit/d1104de8db33cdfe0de1e73999ae0331350a51d0

[Paul Berry, 2016-04-01 19:13:03]

lgtm

https://codereview.chromium.org/1854863002/diff/1/pkg/analyzer/test/src/conte...
File pkg/analyzer/test/src/context/context_test.dart (left):

https://codereview.chromium.org/1854863002/diff/1/pkg/analyzer/test/src/conte...
pkg/analyzer/test/src/context/context_test.dart:2123:
entry.setState(RESOLVED_UNIT2, CacheState.FLUSHED);
Was this line deleted by mistake?  It seems like for purposes of this test we
should flush all the resolved units.

[scheglov, 2016-04-01 19:49:15]

https://codereview.chromium.org/1854863002/diff/1/pkg/analyzer/test/src/conte...
File pkg/analyzer/test/src/context/context_test.dart (left):

https://codereview.chromium.org/1854863002/diff/1/pkg/analyzer/test/src/conte...
pkg/analyzer/test/src/context/context_test.dart:2123:
entry.setState(RESOLVED_UNIT2, CacheState.FLUSHED);
On 2016/04/01 19:13:03, Paul Berry wrote:
> Was this line deleted by mistake?  It seems like for purposes of this test we
> should flush all the resolved units.

Acknowledged.

[Brian Wilkerson, 2016-04-01 20:12:53]

LGTM, although there are way too many places where the same list of result
descriptors is repeated. It would be great to fix that at some point.

https://codereview.chromium.org/1854863002/diff/20001/pkg/analyzer/lib/src/su...
File pkg/analyzer/lib/src/summary/summary_sdk.dart (left):

https://codereview.chromium.org/1854863002/diff/20001/pkg/analyzer/lib/src/su...
pkg/analyzer/lib/src/summary/summary_sdk.dart:97: result ==
CREATED_RESOLVED_UNIT2 ||
Not sure why this isn't still part of the list.

[scheglov, 2016-04-01 21:00:45]

Description was changed from

==========
Issue 26096. Explicitly compute the result that ensures that directives are
resolved in units.

In the past computing LIBRARY_ELEMENT2 also set elements for directives
in the defining unit AST. But when this unit is flushed and reparsed
we didn't set these directive elements again because LIBRARY_ELEMENT2
is valid. Now resolving directive ASTs to elements is an explicit
dependency.

R=brianwilkerson@google.com, paulberry@google.com
BUG= https://github.com/dart-lang/sdk/issues/26096
==========

to

==========
Issue 26096. Explicitly compute the result that ensures that directives are
resolved in units.

In the past computing LIBRARY_ELEMENT2 also set elements for directives
in the defining unit AST. But when this unit is flushed and reparsed
we didn't set these directive elements again because LIBRARY_ELEMENT2
is valid. Now resolving directive ASTs to elements is an explicit
dependency.

R=brianwilkerson@google.com, paulberry@google.com
BUG= https://github.com/dart-lang/sdk/issues/26096

Committed:
https://github.com/dart-lang/sdk/commit/d1104de8db33cdfe0de1e73999ae0331350a51d0
==========

[scheglov, 2016-04-01 21:00:47]

Committed patchset #2 (id:20001) manually as
d1104de8db33cdfe0de1e73999ae0331350a51d0 (presubmit successful).

[Paul Berry, 2016-04-03 12:14:36]

On 2016/04/01 21:00:47, scheglov wrote:
> Committed patchset #2 (id:20001) manually as
> d1104de8db33cdfe0de1e73999ae0331350a51d0 (presubmit successful).

This seems to have broken some unit tests.

Repro: python tools/test.py -aia32 --checked -mrelease -t60
pkg/analyzer/test/generated/hint_code_test

Failing test cases:

FAIL: HintCodeTest | test_unusedImport_hide
  Expected 1 errors of type HintCode.UNUSED_IMPORT, found 0
  package:unittest/src/simple_configuration.dart 128:34      
SimpleConfiguration.onExpectFailure
  package:unittest/src/simple_configuration.dart 24:13       
_ExpectFailureHandler.fail
  package:unittest/src/matcher/expect.dart 103:18             fail
  pkg/analyzer/test/generated/test_support.dart 330:7        
GatheringErrorListener.assertErrorsWithCodes
  pkg/analyzer/test/generated/resolver_test_case.dart 387:19 
ResolverTestCase.assertErrors
  pkg/analyzer/test/generated/hint_code_test.dart 2707:5     
HintCodeTest.test_unusedImport_hide
  dart:mirrors-patch/mirrors_impl.dart 533                   
_LocalInstanceMirror._invoke
  dart:mirrors-patch/mirrors_impl.dart 529                   
_LocalInstanceMirror.invoke
  pkg/analyzer/test/reflective_tests.dart 112:35              _runTest.<fn>
  dart:async/zone.dart 902                                    _rootRunUnary
  dart:async/zone.dart 798                                   
_CustomZone.runUnary
  dart:async/future_impl.dart 553                            
_Future._propagateToListeners.handleValueCallback
  dart:async/future_impl.dart 639                            
_Future._propagateToListeners
  dart:async/future_impl.dart 426                            
_Future._completeWithValue
  dart:async/future_impl.dart 481                            
_Future._asyncComplete.<fn>
  dart:async/zone.dart 895                                    _rootRun
  dart:async/zone.dart 790                                    _CustomZone.run
  dart:async/zone.dart 696                                   
_CustomZone.runGuarded
  dart:async/zone.dart 721                                   
_CustomZone.bindCallback.<fn>
  dart:async/schedule_microtask.dart 41                       _microtaskLoop
  dart:async/schedule_microtask.dart 50                      
_startMicrotaskLoop
  dart:isolate-patch/timer_impl.dart 394                      _Timer._runTimers
  dart:isolate-patch/timer_impl.dart 414                     
_Timer._handleMessage
  dart:isolate-patch/isolate_patch.dart 148                  
_RawReceivePortImpl._handleMessage
FAIL: HintCodeTest | test_unusedImport_show
  Expected 1 errors of type HintCode.UNUSED_IMPORT, found 0
  package:unittest/src/simple_configuration.dart 128:34      
SimpleConfiguration.onExpectFailure
  package:unittest/src/simple_configuration.dart 24:13       
_ExpectFailureHandler.fail
  package:unittest/src/matcher/expect.dart 103:18             fail
  pkg/analyzer/test/generated/test_support.dart 330:7        
GatheringErrorListener.assertErrorsWithCodes
  pkg/analyzer/test/generated/resolver_test_case.dart 387:19 
ResolverTestCase.assertErrors
  pkg/analyzer/test/generated/hint_code_test.dart 2734:5     
HintCodeTest.test_unusedImport_show
  dart:mirrors-patch/mirrors_impl.dart 533                   
_LocalInstanceMirror._invoke
  dart:mirrors-patch/mirrors_impl.dart 529                   
_LocalInstanceMirror.invoke
  pkg/analyzer/test/reflective_tests.dart 112:35              _runTest.<fn>
  dart:async/zone.dart 902                                    _rootRunUnary
  dart:async/zone.dart 798                                   
_CustomZone.runUnary
  dart:async/future_impl.dart 553                            
_Future._propagateToListeners.handleValueCallback
  dart:async/future_impl.dart 639                            
_Future._propagateToListeners
  dart:async/future_impl.dart 426                            
_Future._completeWithValue
  dart:async/future_impl.dart 481                            
_Future._asyncComplete.<fn>
  dart:async/zone.dart 895                                    _rootRun
  dart:async/zone.dart 790                                    _CustomZone.run
  dart:async/zone.dart 696                                   
_CustomZone.runGuarded
  dart:async/zone.dart 721                                   
_CustomZone.bindCallback.<fn>
  dart:async/schedule_microtask.dart 41                       _microtaskLoop
  dart:async/schedule_microtask.dart 50                      
_startMicrotaskLoop
  dart:isolate-patch/timer_impl.dart 394                      _Timer._runTimers
  dart:isolate-patch/timer_impl.dart 414                     
_Timer._handleMessage
  dart:isolate-patch/isolate_patch.dart 148                  
_RawReceivePortImpl._handleMessage

Would you mind having a look?

[scheglov, 2016-04-03 16:38:23]

On 2016/04/03 12:14:36, Paul Berry wrote:
> On 2016/04/01 21:00:47, scheglov wrote:
> > Committed patchset #2 (id:20001) manually as
> > d1104de8db33cdfe0de1e73999ae0331350a51d0 (presubmit successful).
> 
> This seems to have broken some unit tests.
> 
> Repro: python tools/test.py -aia32 --checked -mrelease -t60
> pkg/analyzer/test/generated/hint_code_test

Looking...

[scheglov, 2016-04-03 17:45:13]

On 2016/04/03 16:38:23, scheglov wrote:
> On 2016/04/03 12:14:36, Paul Berry wrote:
> > On 2016/04/01 21:00:47, scheglov wrote:
> > > Committed patchset #2 (id:20001) manually as
> > > d1104de8db33cdfe0de1e73999ae0331350a51d0 (presubmit successful).
> > 
> > This seems to have broken some unit tests.
> > 
> > Repro: python tools/test.py -aia32 --checked -mrelease -t60
> > pkg/analyzer/test/generated/hint_code_test
> 
> Looking...

https://codereview.chromium.org/1854003003