pkg/analyzer/lib/src/context/context.dart - Issue 1854863002: Issue 26096. Explicitly compute the result that ensures that directives are resolved in units.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer/lib/src/context/context.dart

Issue 1854863002: Issue 26096. Explicitly compute the result that ensures that directives are resolved in units. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Fix for a review comment. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/status/get_handler.dart ('k') | pkg/analyzer/lib/src/generated/incremental_resolver.dart » ('j') | pkg/analyzer/lib/src/summary/summary_sdk.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analyzer/lib/src/context/context.dart

diff --git a/pkg/analyzer/lib/src/context/context.dart b/pkg/analyzer/lib/src/context/context.dart

index d2659baf50c4ab302d1c92cf233bc72c992fd65e..e4cfc2959e113419f85b1d83eb65522f73edc7e5 100644

--- a/pkg/analyzer/lib/src/context/context.dart

+++ b/pkg/analyzer/lib/src/context/context.dart

@@ -1238,6 +1238,7 @@ class AnalysisContextImpl implements InternalAnalysisContext {

entry.setState(RESOLVED_UNIT9, CacheState.FLUSHED);

entry.setState(RESOLVED_UNIT10, CacheState.FLUSHED);

entry.setState(RESOLVED_UNIT11, CacheState.FLUSHED);

+ entry.setState(RESOLVED_UNIT12, CacheState.FLUSHED);

// USED_IMPORTED_ELEMENTS

// USED_LOCAL_ELEMENTS

setValue(STRONG_MODE_ERRORS, AnalysisError.NO_ERRORS);

@@ -1316,6 +1317,7 @@ class AnalysisContextImpl implements InternalAnalysisContext {

entry.setState(RESOLVED_UNIT9, CacheState.FLUSHED);

entry.setState(RESOLVED_UNIT10, CacheState.FLUSHED);

entry.setState(RESOLVED_UNIT11, CacheState.FLUSHED);

+ entry.setState(RESOLVED_UNIT12, CacheState.FLUSHED);

entry.setState(RESOLVED_UNIT, CacheState.FLUSHED);

}

@@ -1551,12 +1553,12 @@ class AnalysisContextImpl implements InternalAnalysisContext {

new LibrarySpecificUnit(librarySource, unitSource);

for (ResultDescriptor result in [

RESOLVED_UNIT,

+ RESOLVED_UNIT12,

RESOLVED_UNIT11,

RESOLVED_UNIT10,

RESOLVED_UNIT9,

RESOLVED_UNIT8,

- RESOLVED_UNIT7,

- RESOLVED_UNIT6

+ RESOLVED_UNIT7

]) {

CompilationUnit unit = getResult(target, result);

if (unit != null) {