pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart - Issue 1854863002: Issue 26096. Explicitly compute the result that ensures that directives are resolved in units.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart

Issue 1854863002: Issue 26096. Explicitly compute the result that ensures that directives are resolved in units. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Fix for a review comment. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/completion/dart/common_usage_sorter.dart ('k') | pkg/analysis_server/lib/src/status/get_handler.dart » ('j') | pkg/analyzer/lib/src/summary/summary_sdk.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart

diff --git a/pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart b/pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart

index 42d6823b4ab39cda6a353b184559b5c2ea2f8cdd..21ba3c7f000d51b8f5dd75e9e68e0de1c0750ec9 100644

--- a/pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart

+++ b/pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart

@@ -299,7 +299,7 @@ class DartCompletionRequestImpl implements DartCompletionRequest {

CompilationUnit unit = await _computeAsync(

this,

new LibrarySpecificUnit(libElem.source, unresolvedUnit.source),

- RESOLVED_UNIT3,

+ RESOLVED_UNIT4,

performance,

'resolve library unit');

checkAborted();

@@ -376,7 +376,7 @@ class DartCompletionRequestImpl implements DartCompletionRequest {

unit = await _computeAsync(

request,

new LibrarySpecificUnit(libSource, source),

- resultDescriptor ?? RESOLVED_UNIT3,

+ resultDescriptor ?? RESOLVED_UNIT4,

performance,

'resolve declarations');

}