Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1145)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 18548003: Rename ExceptionCode constants to use the names in the spec (2/3) (Closed)

Created:
7 years, 5 months ago by arv (Not doing code reviews)
Modified:
7 years, 5 months ago
CC:
blink-reviews, webcomponents-bugzilla_chromium.org, eae+blinkwatch, dominicc+watchlist_chromium.org, apavlov+blink_chromium.org, adamk+blink_chromium.org, pdr, aandrey+blink_chromium.org, do-not-use, Nils Barth (inactive), caseq+blink_chromium.org, alecflett, yurys+blink_chromium.org, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, Rik, gavinp+loader_chromium.org, loislo+blink_chromium.org, lushnikov+blink_chromium.org, kinuko, feature-media-reviews_chromium.org, tommyw+watchlist_chromium.org, darktears, haraken, Nate Chapin, vcarbune.chromium, jsbell, jsbell+bindings_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, f(malita), dgrogan, Stephen Chennney, jeez
Visibility:
Public.

Description

Rename ExceptionCode constants to use the names in the spec For example: INDEX_SIZE_ERR -> IndexSizeError Patch 2 of 3 BUG=None R=abarth@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153690

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+582 lines, -577 lines) Patch
M Source/WebKit/chromium/src/AssertMatchingEnums.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/WebKit/chromium/src/StorageAreaProxy.cpp View 7 chunks +7 lines, -7 lines 0 comments Download
M Source/bindings/scripts/CodeGeneratorV8.pm View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/SerializedScriptValue.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/v8/V8Callback.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/V8Utilities.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/custom/V8CustomXPathNSResolver.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8DocumentCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/custom/V8SQLTransactionCustom.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/v8/custom/V8SQLTransactionSyncCustom.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/v8/custom/V8WindowCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSGroupingRule.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/css/CSSMatrix.cpp View 2 chunks +5 lines, -4 lines 0 comments Download
M Source/core/css/CSSPrimitiveValue.cpp View 7 chunks +7 lines, -7 lines 0 comments Download
M Source/core/css/CSSStyleSheet.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/PropertySetCSSStyleDeclaration.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Attr.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/CustomElementRegistry.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/dom/DatasetDOMStringMap.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/Document.cpp View 11 chunks +15 lines, -15 lines 0 comments Download
M Source/core/dom/Element.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/dom/EventTarget.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ExceptionCode.h View 2 chunks +9 lines, -9 lines 0 comments Download
M Source/core/dom/MessagePort.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/MutationObserver.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Node.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M Source/core/dom/NodeIterator.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/Range.cpp View 30 chunks +30 lines, -30 lines 0 comments Download
M Source/core/dom/SelectorQuery.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/dom/shadow/ShadowRoot.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/markup.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fileapi/FileReader.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/DOMTokenList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLCanvasElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLDialogElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLElement.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLInputElement.cpp View 11 chunks +11 lines, -11 lines 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 7 chunks +14 lines, -14 lines 0 comments Download
M Source/core/html/HTMLOptionsCollection.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLSelectElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLVideoElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/InputType.cpp View 5 chunks +8 lines, -8 lines 0 comments Download
M Source/core/html/NumberInputType.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/canvas/CanvasGradient.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/CanvasPattern.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.cpp View 13 chunks +15 lines, -15 lines 0 comments Download
M Source/core/html/canvas/WebGLRenderingContext.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/track/TextTrack.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/track/TextTrackCue.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/track/TextTrackRegion.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorDOMStorageAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorStyleSheet.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/core/loader/appcache/DOMApplicationCache.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/page/DOMSelection.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/page/DOMWindow.cpp View 6 chunks +8 lines, -8 lines 0 comments Download
M Source/core/page/EventSource.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/page/History.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/Location.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/PerformanceUserTiming.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/platform/chromium/ClipboardChromium.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGAngle.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGLength.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGLocatable.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGMatrix.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/properties/SVGTransformListPropertyTearOff.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/testing/InternalSettings.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/testing/Internals.cpp View 93 chunks +102 lines, -102 lines 0 comments Download
M Source/core/workers/AbstractWorker.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/workers/SharedWorker.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/WorkerGlobalScope.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xml/XMLHttpRequest.cpp View 16 chunks +21 lines, -21 lines 0 comments Download
M Source/core/xml/XMLSerializer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xml/XPathExpression.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xml/XPathParser.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/xml/XPathResult.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/crypto/Crypto.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/encryptedmedia/MediaKeySession.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/encryptedmedia/MediaKeys.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/modules/indexeddb/IDBCursor.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/modules/indexeddb/IDBDatabase.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M Source/modules/indexeddb/IDBFactory.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/indexeddb/IDBIndex.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M Source/modules/indexeddb/IDBObjectStore.cpp View 11 chunks +12 lines, -12 lines 0 comments Download
M Source/modules/indexeddb/IDBRequest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/indexeddb/IDBTransaction.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/mediasource/MediaSource.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/modules/mediasource/MediaSourceBase.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/modules/mediasource/SourceBuffer.cpp View 7 chunks +16 lines, -16 lines 0 comments Download
M Source/modules/mediasource/WebKitMediaSource.cpp View 3 chunks +8 lines, -8 lines 0 comments Download
M Source/modules/mediasource/WebKitSourceBuffer.cpp View 5 chunks +13 lines, -13 lines 0 comments Download
M Source/modules/mediastream/MediaConstraintsImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediastream/MediaStream.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/modules/mediastream/RTCDTMFSender.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/mediastream/RTCDataChannel.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/modules/mediastream/RTCIceCandidate.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediastream/RTCPeerConnection.cpp View 14 chunks +27 lines, -27 lines 0 comments Download
M Source/modules/mediastream/RTCSessionDescription.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/navigatorcontentutils/NavigatorContentUtils.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/modules/notifications/Notification.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/modules/notifications/NotificationCenter.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/speech/SpeechRecognition.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webaudio/AudioBuffer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webaudio/AudioContext.cpp View 10 chunks +11 lines, -11 lines 0 comments Download
M Source/modules/webaudio/AudioNode.cpp View 7 chunks +9 lines, -8 lines 0 comments Download
M Source/modules/webaudio/DefaultAudioDestinationNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webaudio/OfflineAudioContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webaudio/WaveShaperNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/DOMWindowWebDatabase.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M Source/modules/webdatabase/DatabaseBackendBase.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M Source/modules/webdatabase/DatabaseManager.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/webdatabase/SQLResultSet.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/webdatabase/SQLTransaction.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webdatabase/WorkerGlobalScopeWebDatabase.cpp View 2 chunks +6 lines, -4 lines 0 comments Download
M Source/modules/websockets/WebSocket.cpp View 11 chunks +16 lines, -16 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
arv (Not doing code reviews)
7 years, 5 months ago (2013-07-02 18:18:16 UTC) #1
abarth-chromium
rs=me LGTM Feel free to TBR these changes to me.
7 years, 5 months ago (2013-07-02 19:03:10 UTC) #2
arv (Not doing code reviews)
7 years, 5 months ago (2013-07-08 17:41:54 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 manually as r153690 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698