Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Unified Diff: Source/core/dom/ExceptionCode.h

Issue 18548003: Rename ExceptionCode constants to use the names in the spec (2/3) (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/dom/EventTarget.cpp ('k') | Source/core/dom/MessagePort.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/ExceptionCode.h
diff --git a/Source/core/dom/ExceptionCode.h b/Source/core/dom/ExceptionCode.h
index 96ca9bc0db210eb7eb0bdb66ceb28d28afb7d2a3..caaeef4d95fb7772ffc3f6415258c3de0bd8ab63 100644
--- a/Source/core/dom/ExceptionCode.h
+++ b/Source/core/dom/ExceptionCode.h
@@ -40,21 +40,21 @@ namespace WebCore {
NotSupportedError,
InuseAttributeError, // Historical. Only used in setAttributeNode etc which have been removed from the DOM specs.
- // FIXME: Rename these to use CamelCase matching the exception name.
// Introduced in DOM Level 2:
- INVALID_STATE_ERR,
- SYNTAX_ERR,
- INVALID_MODIFICATION_ERR,
- NAMESPACE_ERR,
- INVALID_ACCESS_ERR,
+ InvalidStateError,
+ SyntaxError,
+ InvalidModificationError,
+ NamespaceError,
+ InvalidAccessError,
// Introduced in DOM Level 3:
- TYPE_MISMATCH_ERR, // Historical; use TypeError instead
+ TypeMismatchError, // Historical; use TypeError instead
// XMLHttpRequest extension:
- SECURITY_ERR,
+ SecurityError,
// Others introduced in HTML5:
+ // FIXME: Rename these to use CamelCase matching the exception name.
NETWORK_ERR,
ABORT_ERR,
URL_MISMATCH_ERR,
@@ -82,7 +82,7 @@ namespace WebCore {
FSNoModificationAllowedError,
FSInvalidStateError,
FSSyntaxError,
- FSInvalidModificationError,
+ FSInvalidModificationError, // FIXME: This seems to be only used by the file system
FSQuotaExceededError,
FSTypeMismatchError,
FSPathExistsError,
« no previous file with comments | « Source/core/dom/EventTarget.cpp ('k') | Source/core/dom/MessagePort.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698