Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Unified Diff: Source/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp

Issue 18548003: Rename ExceptionCode constants to use the names in the spec (2/3) (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp
diff --git a/Source/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp b/Source/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp
index 75644026e25ff87f4f400c453cf202f9c571d2b4..2e8923f0e5065f32aaecb19003875346a3fdce07 100644
--- a/Source/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp
+++ b/Source/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp
@@ -596,7 +596,7 @@ static void vertexAttribAndUniformHelperf(const v8::FunctionCallbackInfo<v8::Val
float* data = jsArrayToFloatArray(array, len);
if (!data) {
// FIXME: consider different / better exception type.
- setDOMException(SYNTAX_ERR, args.GetIsolate());
+ setDOMException(SyntaxError, args.GetIsolate());
return;
}
ExceptionCode ec = 0;
@@ -671,7 +671,7 @@ static void uniformHelperi(const v8::FunctionCallbackInfo<v8::Value>& args, Func
int* data = jsArrayToIntArray(array, len);
if (!data) {
// FIXME: consider different / better exception type.
- setDOMException(SYNTAX_ERR, args.GetIsolate());
+ setDOMException(SyntaxError, args.GetIsolate());
return;
}
ExceptionCode ec = 0;
@@ -782,7 +782,7 @@ static void uniformMatrixHelper(const v8::FunctionCallbackInfo<v8::Value>& args,
float* data = jsArrayToFloatArray(array, len);
if (!data) {
// FIXME: consider different / better exception type.
- setDOMException(SYNTAX_ERR, args.GetIsolate());
+ setDOMException(SyntaxError, args.GetIsolate());
return;
}
ExceptionCode ec = 0;
« no previous file with comments | « Source/bindings/v8/custom/V8SQLTransactionSyncCustom.cpp ('k') | Source/bindings/v8/custom/V8WindowCustom.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698