Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 185463005: Revert Event back (from RefCountedWillBeRefCountedGarbageCollected) to RefCounted (Closed)

Created:
6 years, 9 months ago by haraken
Modified:
6 years, 9 months ago
CC:
blink-reviews
Visibility:
Public.

Description

Revert Event back (from RefCountedWillBeRefCountedGarbageCollected) to RefCounted Moving Event to oilpan's heap caused a lot of crashes/failures. So this CL reverts Event back to RefCounted. This CL is a revert for https://codereview.chromium.org/182063004/. However, this CL does not revert trace() methods in the original CL because there is no harm in having trace() methods in the code base. (If I revert trace() methods, I have to resolve a bunch of conflicts manually, which will be more dangerous than leaving trace() methods in the code base.) BUG=340522 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168354

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M Source/core/events/Event.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/MouseEvent.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (0 generated)
haraken
PTAL
6 years, 9 months ago (2014-03-03 13:07:34 UTC) #1
Mads Ager (chromium)
LGTM We want to get in a position where we can reland this soon so ...
6 years, 9 months ago (2014-03-03 13:10:11 UTC) #2
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 9 months ago (2014-03-03 13:11:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/185463005/1
6 years, 9 months ago (2014-03-03 13:12:02 UTC) #4
wibling-chromium
lgtm
6 years, 9 months ago (2014-03-03 13:43:44 UTC) #5
wibling-chromium
On 2014/03/03 13:43:44, wibling-chromium wrote: > lgtm I will revert back my persistent to member ...
6 years, 9 months ago (2014-03-03 13:44:37 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-03 17:20:35 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_layout for step(s) webkit_lint http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout&number=24631
6 years, 9 months ago (2014-03-03 17:20:36 UTC) #8
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 9 months ago (2014-03-03 23:11:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/185463005/1
6 years, 9 months ago (2014-03-03 23:12:10 UTC) #10
haraken
The CQ bit was unchecked by haraken@chromium.org
6 years, 9 months ago (2014-03-03 23:22:20 UTC) #11
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 9 months ago (2014-03-03 23:22:26 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/185463005/1
6 years, 9 months ago (2014-03-03 23:24:21 UTC) #13
haraken
The CQ bit was unchecked by haraken@chromium.org
6 years, 9 months ago (2014-03-04 00:58:26 UTC) #14
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 9 months ago (2014-03-04 00:58:33 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-04 01:11:10 UTC) #16
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 9 months ago (2014-03-04 01:11:11 UTC) #17
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 9 months ago (2014-03-04 01:29:18 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/185463005/1
6 years, 9 months ago (2014-03-04 01:29:25 UTC) #19
commit-bot: I haz the power
6 years, 9 months ago (2014-03-04 03:10:16 UTC) #20
Message was sent while issue was closed.
Change committed as 168354

Powered by Google App Engine
This is Rietveld 408576698