Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 182063004: Rename adoptRefCountedWillBeRefCountedGarbageCollected to adoptRefWillBeRefCountedGarbageCollected (Closed)

Created:
6 years, 9 months ago by haraken
Modified:
6 years, 9 months ago
CC:
blink-reviews, Manuel Rego, fs, eric.carlson_apple.com, apavlov+blink_chromium.org, rune+blink, krit, dglazkov+blink, pdr., rwlbuis, kenneth.christiansen, jfernandez, Mads Ager (chromium), eae+blinkwatch, philipj_slow, feature-media-reviews_chromium.org, gyuyoung.kim_webkit.org, darktears, haraken, svillar, ed+blinkwatch_opera.com, f(malita), Stephen Chennney
Visibility:
Public.

Description

Rename adoptRefCountedWillBeRefCountedGarbageCollected to adoptRefWillBeRefCountedGarbageCollected This is for naming consistency. A name of transition types should have a format of existing_name + "WillBe" + oilpan_name. (e.g., adoptRefWillBeNoop, adoptPtrWillBeNoop etc) Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167996

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -103 lines) Patch
M Source/core/css/CSSArrayFunctionValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSArrayFunctionValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSAspectRatioValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSBorderImageSliceValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSCalculationValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSCalculationValue.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSCanvasValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSCharsetRule.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSCrossfadeValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSCursorImageValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSFilterRule.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSFilterValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSFilterValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSFontFaceRule.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSFontFaceSrcValue.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSFontFeatureValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSFontValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSFunctionValue.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSGradientValue.h View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/css/CSSGridLineNamesValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSGridLineNamesValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSGridTemplateAreasValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSImageSetValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSImageSetValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSImageValue.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSImportRule.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSInheritedValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSInitialValue.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSKeyframesRule.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSKeyframesRule.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSLineBoxContainValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSMediaRule.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSPageRule.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSPrimitiveValue.h View 2 chunks +10 lines, -10 lines 0 comments Download
M Source/core/css/CSSReflectValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSSVGDocumentValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSShadowValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSStyleRule.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSSupportsRule.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSTimingFunctionValue.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSTransformValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSTransformValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSUnicodeRangeValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSValueList.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/css/CSSValueList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSViewportRule.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/EventSource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGColor.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGColor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPaint.h View 2 chunks +9 lines, -9 lines 0 comments Download
M Source/core/svg/SVGPaint.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/timing/Performance.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xml/XMLHttpRequest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/heap/Handle.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/heap/HeapTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/encryptedmedia/MediaKeySession.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediasource/MediaSource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediasource/SourceBuffer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediasource/SourceBufferList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediasource/WebKitMediaSource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediasource/WebKitSourceBufferList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/notifications/Notification.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/notifications/WebKitNotification.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/speech/SpeechRecognition.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/speech/SpeechSynthesis.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/speech/SpeechSynthesisUtterance.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webmidi/MIDIAccess.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webmidi/MIDIAccessPromise.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webmidi/MIDIInput.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webmidi/MIDIOutput.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
haraken
PTAL
6 years, 9 months ago (2014-02-27 05:32:25 UTC) #1
kouhei (in TOK)
sgtm lgtm
6 years, 9 months ago (2014-02-27 05:39:52 UTC) #2
zerny-chromium
lgtm
6 years, 9 months ago (2014-02-27 06:38:19 UTC) #3
Mads Ager (chromium)
lgtm
6 years, 9 months ago (2014-02-27 06:49:05 UTC) #4
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 9 months ago (2014-02-27 06:53:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/182063004/1
6 years, 9 months ago (2014-02-27 06:53:52 UTC) #6
commit-bot: I haz the power
6 years, 9 months ago (2014-02-27 09:20:57 UTC) #7
Message was sent while issue was closed. 
Change committed as 167996

Powered by Google App Engine
This is Rietveld 408576698