Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 185413025: Moved policy unittests into the policy component. (Closed)

Created:
6 years, 9 months ago by Joao da Silva
Modified:
6 years, 9 months ago
Reviewers:
dconnelly, Jói, blundell
CC:
chromium-reviews, benjhayden+dwatch_chromium.org, asanka, cbentzel+watch_chromium.org, blundell
Visibility:
Public.

Description

Moved policy unittests into the policy component. These tests weren't moved into the policy component together with the code because the components_unittests test runner didn't set up the resource bundle the same way that the unittests runner did, which caused these tests to fail. That has since been fixed, so the tests can now be moved. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256365

Patch Set 1 #

Patch Set 2 : reupload #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+484 lines, -1026 lines) Patch
M chrome/browser/download/download_dir_policy_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/proxy_policy_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/policy/configuration_policy_handler_unittest.cc View 1 chunk +0 lines, -491 lines 0 comments Download
D chrome/browser/policy/configuration_policy_pref_store_test.h View 1 chunk +0 lines, -43 lines 0 comments Download
D chrome/browser/policy/configuration_policy_pref_store_test.cc View 1 chunk +0 lines, -45 lines 0 comments Download
D chrome/browser/policy/configuration_policy_pref_store_unittest.cc View 1 chunk +0 lines, -213 lines 0 comments Download
M chrome/browser/policy/javascript_policy_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/policy/url_blacklist_policy_handler_unittest.cc View 1 chunk +0 lines, -219 lines 0 comments Download
M chrome/browser/profiles/incognito_mode_policy_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/default_search_policy_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M components/components_tests.gyp View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M components/policy.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M components/policy/core/browser/configuration_policy_handler_unittest.cc View 3 chunks +471 lines, -1 line 0 comments Download
A + components/policy/core/browser/configuration_policy_pref_store_test.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/policy/core/browser/configuration_policy_pref_store_test.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/policy/core/browser/configuration_policy_pref_store_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/policy/core/browser/url_blacklist_policy_handler_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
Joao da Silva
Daniel, please review this one. Colin: FYI Thanks!
6 years, 9 months ago (2014-03-04 23:54:59 UTC) #1
blundell
w00t!
6 years, 9 months ago (2014-03-05 14:21:53 UTC) #2
dconnelly
lgtm
6 years, 9 months ago (2014-03-06 19:25:24 UTC) #3
Joao da Silva
The CQ bit was checked by joaodasilva@chromium.org
6 years, 9 months ago (2014-03-06 19:26:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/185413025/20001
6 years, 9 months ago (2014-03-06 19:31:45 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 19:47:15 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clang_dbg
6 years, 9 months ago (2014-03-06 19:47:16 UTC) #7
Joao da Silva
+Jói for components_tests.gyp; please have a look, thanks!
6 years, 9 months ago (2014-03-07 17:31:03 UTC) #8
blundell
components_tests.gyp LGTM (I'm a //components OWNER)
6 years, 9 months ago (2014-03-07 17:55:24 UTC) #9
Joao da Silva
Oh cool, thanks Colin! :-)
6 years, 9 months ago (2014-03-07 18:00:15 UTC) #10
Joao da Silva
The CQ bit was checked by joaodasilva@chromium.org
6 years, 9 months ago (2014-03-07 18:00:21 UTC) #11
Joao da Silva
The CQ bit was unchecked by joaodasilva@chromium.org
6 years, 9 months ago (2014-03-07 18:00:58 UTC) #12
Joao da Silva
The CQ bit was checked by joaodasilva@chromium.org
6 years, 9 months ago (2014-03-11 16:29:07 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/185413025/20001
6 years, 9 months ago (2014-03-11 16:35:39 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-11 16:36:38 UTC) #15
commit-bot: I haz the power
Failed to apply patch for components/components_tests.gyp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 9 months ago (2014-03-11 16:36:41 UTC) #16
Joao da Silva
The CQ bit was checked by joaodasilva@chromium.org
6 years, 9 months ago (2014-03-11 16:44:31 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/185413025/40001
6 years, 9 months ago (2014-03-11 16:45:19 UTC) #18
commit-bot: I haz the power
6 years, 9 months ago (2014-03-12 00:31:38 UTC) #19
Message was sent while issue was closed.
Change committed as 256365

Powered by Google App Engine
This is Rietveld 408576698