Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: chrome/browser/policy/configuration_policy_pref_store_unittest.cc

Issue 185413025: Moved policy unittests into the policy component. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/policy/configuration_policy_pref_store_unittest.cc
diff --git a/chrome/browser/policy/configuration_policy_pref_store_unittest.cc b/chrome/browser/policy/configuration_policy_pref_store_unittest.cc
deleted file mode 100644
index 9a45c6fc9b43487e663a156434cd1a9a87db09b7..0000000000000000000000000000000000000000
--- a/chrome/browser/policy/configuration_policy_pref_store_unittest.cc
+++ /dev/null
@@ -1,213 +0,0 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include <string>
-
-#include "base/callback.h"
-#include "base/files/file_path.h"
-#include "base/prefs/pref_store_observer_mock.h"
-#include "base/run_loop.h"
-#include "chrome/browser/policy/configuration_policy_pref_store_test.h"
-#include "components/policy/core/browser/configuration_policy_handler.h"
-#include "components/policy/core/browser/configuration_policy_pref_store.h"
-#include "components/policy/core/common/external_data_fetcher.h"
-#include "components/policy/core/common/policy_details.h"
-#include "components/policy/core/common/policy_map.h"
-#include "components/policy/core/common/policy_pref_names.h"
-#include "components/policy/core/common/policy_service_impl.h"
-#include "testing/gmock/include/gmock/gmock.h"
-
-// Note: this file should move to components/policy/core/browser, but the
-// components_unittests runner does not load the ResourceBundle as
-// ChromeTestSuite::Initialize does, which leads to failures using
-// PolicyErrorMap.
-
-using testing::Mock;
-using testing::Return;
-using testing::_;
-
-namespace {
-
-const char kTestPolicy[] = "test.policy";
-const char kTestPref[] = "test.pref";
-
-} // namespace
-
-namespace policy {
-
-// Test cases for list-valued policy settings.
-class ConfigurationPolicyPrefStoreListTest
- : public ConfigurationPolicyPrefStoreTest {
- virtual void SetUp() OVERRIDE {
- handler_list_.AddHandler(
- make_scoped_ptr<ConfigurationPolicyHandler>(new SimplePolicyHandler(
- kTestPolicy, kTestPref, base::Value::TYPE_LIST)));
- }
-};
-
-TEST_F(ConfigurationPolicyPrefStoreListTest, GetDefault) {
- EXPECT_FALSE(store_->GetValue(kTestPref, NULL));
-}
-
-TEST_F(ConfigurationPolicyPrefStoreListTest, SetValue) {
- base::ListValue* in_value = new base::ListValue();
- in_value->Append(base::Value::CreateStringValue("test1"));
- in_value->Append(base::Value::CreateStringValue("test2,"));
- PolicyMap policy;
- policy.Set(kTestPolicy, POLICY_LEVEL_MANDATORY,
- POLICY_SCOPE_USER, in_value, NULL);
- UpdateProviderPolicy(policy);
- const base::Value* value = NULL;
- EXPECT_TRUE(store_->GetValue(kTestPref, &value));
- ASSERT_TRUE(value);
- EXPECT_TRUE(in_value->Equals(value));
-}
-
-// Test cases for string-valued policy settings.
-class ConfigurationPolicyPrefStoreStringTest
- : public ConfigurationPolicyPrefStoreTest {
- virtual void SetUp() OVERRIDE {
- handler_list_.AddHandler(
- make_scoped_ptr<ConfigurationPolicyHandler>(new SimplePolicyHandler(
- kTestPolicy, kTestPref, base::Value::TYPE_STRING)));
- }
-};
-
-TEST_F(ConfigurationPolicyPrefStoreStringTest, GetDefault) {
- EXPECT_FALSE(store_->GetValue(kTestPref, NULL));
-}
-
-TEST_F(ConfigurationPolicyPrefStoreStringTest, SetValue) {
- PolicyMap policy;
- policy.Set(kTestPolicy, POLICY_LEVEL_MANDATORY,
- POLICY_SCOPE_USER,
- base::Value::CreateStringValue("http://chromium.org"), NULL);
- UpdateProviderPolicy(policy);
- const base::Value* value = NULL;
- EXPECT_TRUE(store_->GetValue(kTestPref, &value));
- ASSERT_TRUE(value);
- EXPECT_TRUE(base::StringValue("http://chromium.org").Equals(value));
-}
-
-// Test cases for boolean-valued policy settings.
-class ConfigurationPolicyPrefStoreBooleanTest
- : public ConfigurationPolicyPrefStoreTest {
- virtual void SetUp() OVERRIDE {
- handler_list_.AddHandler(
- make_scoped_ptr<ConfigurationPolicyHandler>(new SimplePolicyHandler(
- kTestPolicy, kTestPref, base::Value::TYPE_BOOLEAN)));
- }
-};
-
-TEST_F(ConfigurationPolicyPrefStoreBooleanTest, GetDefault) {
- EXPECT_FALSE(store_->GetValue(kTestPref, NULL));
-}
-
-TEST_F(ConfigurationPolicyPrefStoreBooleanTest, SetValue) {
- PolicyMap policy;
- policy.Set(kTestPolicy, POLICY_LEVEL_MANDATORY,
- POLICY_SCOPE_USER, base::Value::CreateBooleanValue(false), NULL);
- UpdateProviderPolicy(policy);
- const base::Value* value = NULL;
- EXPECT_TRUE(store_->GetValue(kTestPref, &value));
- ASSERT_TRUE(value);
- bool boolean_value = true;
- bool result = value->GetAsBoolean(&boolean_value);
- ASSERT_TRUE(result);
- EXPECT_FALSE(boolean_value);
-
- policy.Set(kTestPolicy, POLICY_LEVEL_MANDATORY,
- POLICY_SCOPE_USER, base::Value::CreateBooleanValue(true), NULL);
- UpdateProviderPolicy(policy);
- value = NULL;
- EXPECT_TRUE(store_->GetValue(kTestPref, &value));
- boolean_value = false;
- result = value->GetAsBoolean(&boolean_value);
- ASSERT_TRUE(result);
- EXPECT_TRUE(boolean_value);
-}
-
-// Test cases for integer-valued policy settings.
-class ConfigurationPolicyPrefStoreIntegerTest
- : public ConfigurationPolicyPrefStoreTest {
- virtual void SetUp() OVERRIDE {
- handler_list_.AddHandler(
- make_scoped_ptr<ConfigurationPolicyHandler>(new SimplePolicyHandler(
- kTestPolicy, kTestPref, base::Value::TYPE_INTEGER)));
- }
-};
-
-TEST_F(ConfigurationPolicyPrefStoreIntegerTest, GetDefault) {
- EXPECT_FALSE(store_->GetValue(kTestPref, NULL));
-}
-
-TEST_F(ConfigurationPolicyPrefStoreIntegerTest, SetValue) {
- PolicyMap policy;
- policy.Set(kTestPolicy, POLICY_LEVEL_MANDATORY,
- POLICY_SCOPE_USER, base::Value::CreateIntegerValue(2), NULL);
- UpdateProviderPolicy(policy);
- const base::Value* value = NULL;
- EXPECT_TRUE(store_->GetValue(kTestPref, &value));
- EXPECT_TRUE(base::FundamentalValue(2).Equals(value));
-}
-
-// Exercises the policy refresh mechanism.
-class ConfigurationPolicyPrefStoreRefreshTest
- : public ConfigurationPolicyPrefStoreTest {
- protected:
- virtual void SetUp() OVERRIDE {
- ConfigurationPolicyPrefStoreTest::SetUp();
- store_->AddObserver(&observer_);
- handler_list_.AddHandler(
- make_scoped_ptr<ConfigurationPolicyHandler>(new SimplePolicyHandler(
- kTestPolicy, kTestPref, base::Value::TYPE_STRING)));
- }
-
- virtual void TearDown() OVERRIDE {
- store_->RemoveObserver(&observer_);
- ConfigurationPolicyPrefStoreTest::TearDown();
- }
-
- PrefStoreObserverMock observer_;
-};
-
-TEST_F(ConfigurationPolicyPrefStoreRefreshTest, Refresh) {
- const base::Value* value = NULL;
- EXPECT_FALSE(store_->GetValue(kTestPolicy, NULL));
-
- EXPECT_CALL(observer_, OnPrefValueChanged(kTestPref)).Times(1);
- PolicyMap policy;
- policy.Set(kTestPolicy,
- POLICY_LEVEL_MANDATORY,
- POLICY_SCOPE_USER,
- base::Value::CreateStringValue("http://www.chromium.org"),
- NULL);
- UpdateProviderPolicy(policy);
- Mock::VerifyAndClearExpectations(&observer_);
- EXPECT_TRUE(store_->GetValue(kTestPref, &value));
- EXPECT_TRUE(base::StringValue("http://www.chromium.org").Equals(value));
-
- EXPECT_CALL(observer_, OnPrefValueChanged(_)).Times(0);
- UpdateProviderPolicy(policy);
- Mock::VerifyAndClearExpectations(&observer_);
-
- EXPECT_CALL(observer_, OnPrefValueChanged(kTestPref)).Times(1);
- policy.Erase(kTestPolicy);
- UpdateProviderPolicy(policy);
- Mock::VerifyAndClearExpectations(&observer_);
- EXPECT_FALSE(store_->GetValue(kTestPref, NULL));
-}
-
-TEST_F(ConfigurationPolicyPrefStoreRefreshTest, Initialization) {
- EXPECT_FALSE(store_->IsInitializationComplete());
- EXPECT_CALL(provider_, IsInitializationComplete(POLICY_DOMAIN_CHROME))
- .WillRepeatedly(Return(true));
- EXPECT_CALL(observer_, OnInitializationCompleted(true)).Times(1);
- PolicyMap policy;
- UpdateProviderPolicy(policy);
- Mock::VerifyAndClearExpectations(&observer_);
- EXPECT_TRUE(store_->IsInitializationComplete());
-}
-
-} // namespace policy

Powered by Google App Engine
This is Rietveld 408576698