Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2123)

Unified Diff: chrome/browser/policy/url_blacklist_policy_handler_unittest.cc

Issue 185413025: Moved policy unittests into the policy component. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/policy/url_blacklist_policy_handler_unittest.cc
diff --git a/chrome/browser/policy/url_blacklist_policy_handler_unittest.cc b/chrome/browser/policy/url_blacklist_policy_handler_unittest.cc
deleted file mode 100644
index 500f358bd654ac66349c06ea3bfe101b4b538403..0000000000000000000000000000000000000000
--- a/chrome/browser/policy/url_blacklist_policy_handler_unittest.cc
+++ /dev/null
@@ -1,219 +0,0 @@
-// Copyright 2013 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "base/memory/scoped_ptr.h"
-#include "base/prefs/pref_value_map.h"
-#include "base/values.h"
-#include "components/policy/core/browser/policy_error_map.h"
-#include "components/policy/core/browser/url_blacklist_policy_handler.h"
-#include "components/policy/core/common/policy_map.h"
-#include "components/policy/core/common/policy_pref_names.h"
-#include "policy/policy_constants.h"
-#include "testing/gtest/include/gtest/gtest.h"
-
-// Note: this file should move to components/policy/core/browser, but the
-// components_unittests runner does not load the ResourceBundle as
-// ChromeTestSuite::Initialize does, which leads to failures using
-// PolicyErrorMap.
-
-namespace policy {
-
-namespace {
-
-const char kTestDisabledScheme[] = "kTestDisabledScheme";
-const char kTestBlacklistValue[] = "kTestBlacklistValue";
-
-} // namespace
-
-class URLBlacklistPolicyHandlerTest : public testing::Test {
- protected:
- void SetPolicy(const std::string& key, base::Value* value) {
- policies_.Set(key, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER, value, NULL);
- }
- bool CheckPolicy(const std::string& key, base::Value* value) {
- SetPolicy(key, value);
- return handler_.CheckPolicySettings(policies_, &errors_);
- }
- void ApplyPolicies() {
- handler_.ApplyPolicySettings(policies_, &prefs_);
- }
-
- URLBlacklistPolicyHandler handler_;
- PolicyErrorMap errors_;
- PolicyMap policies_;
- PrefValueMap prefs_;
-};
-
-TEST_F(URLBlacklistPolicyHandlerTest,
- CheckPolicySettings_DisabledSchemesUnspecified) {
- EXPECT_TRUE(CheckPolicy(key::kURLBlacklist, new base::ListValue));
- EXPECT_EQ(0U, errors_.size());
-}
-
-TEST_F(URLBlacklistPolicyHandlerTest,
- CheckPolicySettings_URLBlacklistUnspecified) {
- EXPECT_TRUE(CheckPolicy(key::kDisabledSchemes, new base::ListValue));
- EXPECT_EQ(0U, errors_.size());
-}
-
-TEST_F(URLBlacklistPolicyHandlerTest,
- CheckPolicySettings_DisabledSchemesWrongType) {
- // The policy expects a list. Give it a boolean.
- EXPECT_TRUE(CheckPolicy(key::kDisabledSchemes,
- base::Value::CreateBooleanValue(false)));
- EXPECT_EQ(1U, errors_.size());
- const std::string expected = key::kDisabledSchemes;
- const std::string actual = errors_.begin()->first;
- EXPECT_EQ(expected, actual);
-}
-
-TEST_F(URLBlacklistPolicyHandlerTest,
- CheckPolicySettings_URLBlacklistWrongType) {
- // The policy expects a list. Give it a boolean.
- EXPECT_TRUE(CheckPolicy(key::kURLBlacklist,
- base::Value::CreateBooleanValue(false)));
- EXPECT_EQ(1U, errors_.size());
- const std::string expected = key::kURLBlacklist;
- const std::string actual = errors_.begin()->first;
- EXPECT_EQ(expected, actual);
-}
-
-TEST_F(URLBlacklistPolicyHandlerTest, ApplyPolicySettings_NothingSpecified) {
- ApplyPolicies();
- EXPECT_FALSE(prefs_.GetValue(policy_prefs::kUrlBlacklist, NULL));
-}
-
-TEST_F(URLBlacklistPolicyHandlerTest,
- ApplyPolicySettings_DisabledSchemesWrongType) {
- // The policy expects a list. Give it a boolean.
- SetPolicy(key::kDisabledSchemes, base::Value::CreateBooleanValue(false));
- ApplyPolicies();
- EXPECT_FALSE(prefs_.GetValue(policy_prefs::kUrlBlacklist, NULL));
-}
-
-TEST_F(URLBlacklistPolicyHandlerTest,
- ApplyPolicySettings_URLBlacklistWrongType) {
- // The policy expects a list. Give it a boolean.
- SetPolicy(key::kURLBlacklist, base::Value::CreateBooleanValue(false));
- ApplyPolicies();
- EXPECT_FALSE(prefs_.GetValue(policy_prefs::kUrlBlacklist, NULL));
-}
-
-TEST_F(URLBlacklistPolicyHandlerTest,
- ApplyPolicySettings_DisabledSchemesEmpty) {
- SetPolicy(key::kDisabledSchemes, new base::ListValue);
- ApplyPolicies();
- base::Value* out;
- EXPECT_TRUE(prefs_.GetValue(policy_prefs::kUrlBlacklist, &out));
- base::ListValue* out_list;
- EXPECT_TRUE(out->GetAsList(&out_list));
- EXPECT_EQ(0U, out_list->GetSize());
-}
-
-TEST_F(URLBlacklistPolicyHandlerTest,
- ApplyPolicySettings_URLBlacklistEmpty) {
- SetPolicy(key::kURLBlacklist, new base::ListValue);
- ApplyPolicies();
- base::Value* out;
- EXPECT_TRUE(prefs_.GetValue(policy_prefs::kUrlBlacklist, &out));
- base::ListValue* out_list;
- EXPECT_TRUE(out->GetAsList(&out_list));
- EXPECT_EQ(0U, out_list->GetSize());
-}
-
-TEST_F(URLBlacklistPolicyHandlerTest,
- ApplyPolicySettings_DisabledSchemesWrongElementType) {
- // The policy expects string-valued elements. Give it booleans.
- scoped_ptr<base::ListValue> in(new base::ListValue);
- in->AppendBoolean(false);
- SetPolicy(key::kDisabledSchemes, in.release());
- ApplyPolicies();
-
- // The element should be skipped.
- base::Value* out;
- EXPECT_TRUE(prefs_.GetValue(policy_prefs::kUrlBlacklist, &out));
- base::ListValue* out_list;
- EXPECT_TRUE(out->GetAsList(&out_list));
- EXPECT_EQ(0U, out_list->GetSize());
-}
-
-TEST_F(URLBlacklistPolicyHandlerTest,
- ApplyPolicySettings_URLBlacklistWrongElementType) {
- // The policy expects string-valued elements. Give it booleans.
- scoped_ptr<base::ListValue> in(new base::ListValue);
- in->AppendBoolean(false);
- SetPolicy(key::kURLBlacklist, in.release());
- ApplyPolicies();
-
- // The element should be skipped.
- base::Value* out;
- EXPECT_TRUE(prefs_.GetValue(policy_prefs::kUrlBlacklist, &out));
- base::ListValue* out_list;
- EXPECT_TRUE(out->GetAsList(&out_list));
- EXPECT_EQ(0U, out_list->GetSize());
-}
-
-TEST_F(URLBlacklistPolicyHandlerTest,
- ApplyPolicySettings_DisabledSchemesSuccessful) {
- scoped_ptr<base::ListValue> in_disabled_schemes(new base::ListValue);
- in_disabled_schemes->AppendString(kTestDisabledScheme);
- SetPolicy(key::kDisabledSchemes, in_disabled_schemes.release());
- ApplyPolicies();
-
- base::Value* out;
- EXPECT_TRUE(prefs_.GetValue(policy_prefs::kUrlBlacklist, &out));
- base::ListValue* out_list;
- EXPECT_TRUE(out->GetAsList(&out_list));
- EXPECT_EQ(1U, out_list->GetSize());
-
- std::string out_string;
- EXPECT_TRUE(out_list->GetString(0U, &out_string));
- EXPECT_EQ(kTestDisabledScheme + std::string("://*"), out_string);
-}
-
-TEST_F(URLBlacklistPolicyHandlerTest,
- ApplyPolicySettings_URLBlacklistSuccessful) {
- scoped_ptr<base::ListValue> in_url_blacklist(new base::ListValue);
- in_url_blacklist->AppendString(kTestBlacklistValue);
- SetPolicy(key::kURLBlacklist, in_url_blacklist.release());
- ApplyPolicies();
-
- base::Value* out;
- EXPECT_TRUE(prefs_.GetValue(policy_prefs::kUrlBlacklist, &out));
- base::ListValue* out_list;
- EXPECT_TRUE(out->GetAsList(&out_list));
- EXPECT_EQ(1U, out_list->GetSize());
-
- std::string out_string;
- EXPECT_TRUE(out_list->GetString(0U, &out_string));
- EXPECT_EQ(kTestBlacklistValue, out_string);
-}
-
-TEST_F(URLBlacklistPolicyHandlerTest, ApplyPolicySettings_MergeSuccessful) {
- scoped_ptr<base::ListValue> in_disabled_schemes(new base::ListValue);
- in_disabled_schemes->AppendString(kTestDisabledScheme);
- SetPolicy(key::kDisabledSchemes, in_disabled_schemes.release());
-
- scoped_ptr<base::ListValue> in_url_blacklist(new base::ListValue);
- in_url_blacklist->AppendString(kTestBlacklistValue);
- SetPolicy(key::kURLBlacklist, in_url_blacklist.release());
-
- ApplyPolicies();
-
- base::Value* out;
- EXPECT_TRUE(prefs_.GetValue(policy_prefs::kUrlBlacklist, &out));
- base::ListValue* out_list;
- EXPECT_TRUE(out->GetAsList(&out_list));
- EXPECT_EQ(2U, out_list->GetSize());
-
- std::string out1;
- EXPECT_TRUE(out_list->GetString(0U, &out1));
- EXPECT_EQ(kTestDisabledScheme + std::string("://*"), out1);
-
- std::string out2;
- EXPECT_TRUE(out_list->GetString(1U, &out2));
- EXPECT_EQ(kTestBlacklistValue, out2);
-}
-
-} // namespace policy

Powered by Google App Engine
This is Rietveld 408576698