Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Issue 1854053002: Rename |ignore_cache| to |bypass_cache| (Closed)

Created:
4 years, 8 months ago by Takashi Toyoshima
Modified:
4 years, 8 months ago
CC:
cbentzel+watch_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename |ignore_cache| to |bypass_cache| To be aligned with other flags, rename |ignore_cache| to |bypass_cache|. After this change, only Inspector related code use the word 'ignore' to specify Shift-Reload. BUG=599364 Committed: https://crrev.com/24a4c7aba842ce860467501828d91a26418682dd Cr-Commit-Position: refs/heads/master@{#385142}

Patch Set 1 #

Patch Set 2 : [rebase] #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -27 lines) Patch
M chrome/browser/ui/browser.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_commands.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/renderer/net/net_error_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/net/net_error_helper.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M components/error_page/renderer/net_error_helper_core.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/error_page/renderer/net_error_helper_core.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/error_page/renderer/net_error_helper_core_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/frame_messages.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/browser/web_contents.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_frame_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 20 (10 generated)
Takashi Toyoshima
palmer for frame_messages.h jochen for others Please take a look. This contains only mechanical changes.
4 years, 8 months ago (2016-04-04 04:41:40 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1854053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1854053002/1
4 years, 8 months ago (2016-04-04 04:47:25 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-04 05:46:50 UTC) #7
jochen (gone - plz use gerrit)
lgtm
4 years, 8 months ago (2016-04-04 12:08:22 UTC) #8
palmer
lgtm
4 years, 8 months ago (2016-04-04 20:13:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1854053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1854053002/1
4 years, 8 months ago (2016-04-05 06:07:16 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/182130) ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 8 months ago (2016-04-05 06:10:03 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1854053002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1854053002/20001
4 years, 8 months ago (2016-04-05 08:25:37 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-05 09:24:25 UTC) #18
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 09:25:30 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/24a4c7aba842ce860467501828d91a26418682dd
Cr-Commit-Position: refs/heads/master@{#385142}

Powered by Google App Engine
This is Rietveld 408576698