Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2137)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 1854053002: Rename |ignore_cache| to |bypass_cache| (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: [rebase] Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_frame_impl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index c894509f1cac3eb144ba591cd10d378b33af561c..9426ed14004d3eaf9781378f324e80259e8f3a4a 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -2101,10 +2101,8 @@ void RenderFrameImpl::OnPostMessageEvent(
frame_->dispatchMessageEventWithOriginCheck(target_origin, msg_event);
}
-void RenderFrameImpl::OnReload(bool ignore_cache) {
- // TODO(crbug.com/599364): Rename |ignore_cache| or change it to enum.
- // Eventually we may remove FrameMsg_Reload, and use FrameMsg_Navigate.
- frame_->reload(ignore_cache ? WebFrameLoadType::ReloadBypassingCache
+void RenderFrameImpl::OnReload(bool bypass_cache) {
+ frame_->reload(bypass_cache ? WebFrameLoadType::ReloadBypassingCache
: WebFrameLoadType::Reload);
}
@@ -5302,9 +5300,9 @@ void RenderFrameImpl::NavigateInternal(
// corresponds to a back/forward navigation event. Update the parameters
// depending on the navigation type.
if (is_reload) {
- bool ignore_cache = (common_params.navigation_type ==
+ bool bypass_cache = (common_params.navigation_type ==
FrameMsg_Navigate_Type::RELOAD_BYPASSING_CACHE);
- load_type = ignore_cache ? WebFrameLoadType::ReloadBypassingCache
+ load_type = bypass_cache ? WebFrameLoadType::ReloadBypassingCache
: WebFrameLoadType::Reload;
if (!browser_side_navigation) {
« no previous file with comments | « content/renderer/render_frame_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698