components/error_page/renderer/net_error_helper_core.h - Issue 1854053002: Rename |ignore_cache| to |bypass_cache|

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/error_page/renderer/net_error_helper_core.h

Issue 1854053002: Rename |ignore_cache| to |bypass_cache| (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: [rebase] Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/error_page/renderer/net_error_helper_core.h

diff --git a/components/error_page/renderer/net_error_helper_core.h b/components/error_page/renderer/net_error_helper_core.h

index 1dc97e6c4073f51b84493035fdcfed380c127ac6..426cd07d1e1bb4a7af0e69803d9b2583a6859600 100644

--- a/components/error_page/renderer/net_error_helper_core.h

+++ b/components/error_page/renderer/net_error_helper_core.h

@@ -105,7 +105,7 @@ class NetErrorHelperCore {

const std::string& tracking_request_body) = 0;

// Starts a reload of the page in the observed frame.

- virtual void ReloadPage(bool ignore_cache) = 0;

+ virtual void ReloadPage(bool bypass_cache) = 0;

// Load the original page from cache.

virtual void LoadPageFromCache(const GURL& page_url) = 0;

@@ -232,7 +232,7 @@ class NetErrorHelperCore {

blink::WebURLError GetUpdatedError(const blink::WebURLError& error) const;

- void Reload(bool ignore_cache);

+ void Reload(bool bypass_cache);

bool MaybeStartAutoReloadTimer();

void StartAutoReloadTimer();

void AutoReloadTimerFired();